Review main Merged

57684[TASK] Remove static cache in StorageRepository

Christian Kuhn CR +2 V +2 Easy +11 −11 updated 07/25/18, 19:36

Commit message

Class StorageRepository parks static state in property
$storageRowCache. This is ugly and needs proper reset
functionality. However, the class is also a singleton through
AbstractRepository, so there is no need to make $storageRowCache
static in the first place. Just making the property non-static
keeps all the functionality, and removes the hard to
evict static state at the same time.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/25/18, 19:10

  2. Wouter Wolters voted on patch set 1 CR +1 07/25/18, 19:11

  3. Wouter Wolters voted on patch set 1 V +1 07/25/18, 19:14

  4. TYPO3com voted on patch set 1 V +1 07/25/18, 19:18 Completed build in 08m 05s on Wed, 25 Jul, 09:18 PM Test Summary: 33448 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25770

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 07/25/18, 19:36

  6. Andreas Kienast merged patch set 2 07/25/18, 19:36