Review main Merged

57686[TASK] Add require() to php capable cache backend

Christian Kuhn CR +2 V +2 Normal +189 −31 updated 07/25/18, 20:01

Commit message

To allow loading php cache files more than once it is
necessary to add a require() method next to requireOnce()
to cache backends. This can be used if cache entries do
not execute one-time-per-process-only code, if they for
instance do not declare classes. This is needed to execute
for instance the functional test suite multiple times in
one process and to still make use of caching.
The cache_core php cache is affected by this: Those calls
are changed to require() instead of requireOnce() to make
them multi-loadable per request.
Note require() is not yet added to the PhpCapableBackendInterface
since that would be breaking, but marked as todo for v10.0

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1318

  1. Christian Kuhn uploaded patch set 1 07/25/18, 19:25

  2. Christian Kuhn voted on patch set 1 CR -1 07/25/18, 19:28

  3. TYPO3com voted on patch set 1 V +1 07/25/18, 19:32 Completed build in 06m 59s on Wed, 25 Jul, 09:32 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25772

  4. Christian Kuhn uploaded patch set 2 07/25/18, 19:32

  5. Christian Kuhn uploaded patch set 3 07/25/18, 19:38

  6. Wouter Wolters voted on patch set 3 CR +1 07/25/18, 19:39

  7. TYPO3com voted on patch set 2 V +1 07/25/18, 19:40 Completed build in 07m 25s on Wed, 25 Jul, 09:40 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25773

  8. Christian Kuhn voted on patch set 3 CR -2 07/25/18, 19:42

  9. Christian Kuhn uploaded patch set 4 07/25/18, 19:43

  10. Christian Kuhn voted on patch set 4 CR 0 07/25/18, 19:43

  11. TYPO3com voted on patch set 3 V +1 07/25/18, 19:46 Completed build in 07m 42s on Wed, 25 Jul, 09:46 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25774

  12. TYPO3com voted on patch set 4 V +1 07/25/18, 19:50 Completed build in 07m 26s on Wed, 25 Jul, 09:50 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25775

  13. Wouter Wolters voted on patch set 4 V +1 CR +1 07/25/18, 19:51

  14. Andreas Kienast uploaded patch set 5 07/25/18, 19:52

  15. TYPO3com voted on patch set 5 V +1 07/25/18, 19:59 Completed build in 07m 17s on Wed, 25 Jul, 09:59 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25776

  16. Wouter Wolters voted on patch set 5 V +1 CR +1 07/25/18, 20:00

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 07/25/18, 20:01

  18. Andreas Kienast merged patch set 6 07/25/18, 20:01