Review main Merged

57690[BUGFIX] Recreate PackageStates in install tool if missing

Christian Kuhn CR +2 V +2 Easy +26 −2 updated 07/27/18, 14:44

Commit message

v8 has a fallback if PackageStates.php vanished on a running instance
and the install tool is called, a default PackageStates file is
generated that comes with a minimal set of active packages that
allow login to the backend and activating further packages again.

This broke in v9 with the install tool refactoring and is fixed
with the patch: The install tool detects after successful login
if PackageStates.php misses and creates a new one. Note this
operation is not yet messaged to the user. This could be added
later if a true recovery procedure is added to the install tool.
For now, the sole purpose of the patch is to resurrect an instance.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Wolf +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Christian Kuhn uploaded patch set 1 07/26/18, 11:14

  2. TYPO3com voted on patch set 1 V +1 07/26/18, 11:21 Completed build in 07m 09s on Thu, 26 Jul, 01:21 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25803

  3. Markus Klein commented on patch set 1 V +1 CR +1 07/26/18, 12:04

    Thank you very much!
  4. Andreas Wolf voted on patch set 1 V +2 CR +2 07/26/18, 12:17

  5. Andreas Wolf merged patch set 2 07/26/18, 12:17

  6. Nicole Hummel commented on patch set 2 07/26/18, 15:32

    Post -1 I will push an update

    RequestHandler.php:327

    using getEarlyInstance here is IMHO the wrong approach. You need to get an instance of PackageManager instead as you don't use any FailsafePackageManager api
  7. Nicole Hummel commented on patch set 2 07/26/18, 15:50

  8. Markus Klein commented on patch set 2 07/27/18, 13:05

    Thanks Nicole. I linked the tickets on forge
  9. Helmut Hummel commented on patch set 2 07/27/18, 14:43

    RequestHandler.php:327 Reply

    another thing is, that both getInstance, as well as getEarlyInstace are marked for deprecation (not yet deprecated, but still)
  10. Helmut Hummel commented on patch set 2 07/27/18, 14:44

    RequestHandler.php:327 Reply

    in fact forceSortAndSavePackageStates is failsafe package manager api