57690[BUGFIX] Recreate PackageStates in install tool if missing
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Markus Klein +1
-
Verified V +2
- Andreas Wolf +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Christian Kuhn uploaded patch set 1 07/26/18, 11:14
-
TYPO3com voted on patch set 1 V +1 07/26/18, 11:21 Completed build in 07m 09s on Thu, 26 Jul, 01:21 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25803
-
Markus Klein commented on patch set 1 V +1 CR +1 07/26/18, 12:04
Thank you very much! -
Andreas Wolf voted on patch set 1 V +2 CR +2 07/26/18, 12:17
-
Andreas Wolf merged patch set 2 07/26/18, 12:17
-
Nicole Hummel commented on patch set 2 07/26/18, 15:32
Post -1 I will push an updateRequestHandler.php:327using getEarlyInstance here is IMHO the wrong approach. You need to get an instance of PackageManager instead as you don't use any FailsafePackageManager api -
Nicole Hummel commented on patch set 2 07/26/18, 15:50
-
Markus Klein commented on patch set 2 07/27/18, 13:05
Thanks Nicole. I linked the tickets on forge -
Helmut Hummel commented on patch set 2 07/27/18, 14:43
RequestHandler.php:327Replyanother thing is, that both getInstance, as well as getEarlyInstace are marked for deprecation (not yet deprecated, but still) -
Helmut Hummel commented on patch set 2 07/27/18, 14:44
RequestHandler.php:327Replyin fact forceSortAndSavePackageStates is failsafe package manager api