Review main Merged

57692[BUGFIX] Use correct packageManager initializing

Nicole Hummel CR +2 V +2 Easy +5 −2 updated 07/26/18, 20:05

Commit message

As the PackageManager is a singleton class, you should call
GeneralUtility::makeInstance to retrieve the instance. The bootstrap
correctly initializes the first instance and registers it as singleton
already.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Nicole Hummel uploaded patch set 1 07/26/18, 15:49

  2. TYPO3com voted on patch set 1 V +1 07/26/18, 15:56 Completed build in 06m 52s on Thu, 26 Jul, 05:56 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25808

  3. Andreas Wolf voted on patch set 1 CR +1 07/26/18, 17:36

  4. Benni Mack commented on patch set 2 07/26/18, 19:53

    Published edit on patch set 1.
  5. Christian Kuhn voted on patch set 2 V +1 CR +1 07/26/18, 19:54

  6. TYPO3com voted on patch set 2 V +1 07/26/18, 20:01 Completed build in 07m 58s on Thu, 26 Jul, 10:01 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25816

  7. Benni Mack voted on patch set 2 V +2 CR +2 07/26/18, 20:05

  8. Benni Mack merged patch set 3 07/26/18, 20:05