Review main Merged

57693[TASK] Deprecate TSFE->initTemplate

Benni Mack CR +2 V +2 Normal +52 −6 updated 07/27/18, 17:05

Commit message

The method only does one line of code, and is now instantiated if needed.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 810

  1. Benni Mack uploaded patch set 1 07/26/18, 18:33

  2. TYPO3com voted on patch set 1 V +1 07/26/18, 18:39 Completed build in 06m 15s on Thu, 26 Jul, 08:39 PM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25809

  3. Benni Mack voted on patch set 1 CR -1 07/26/18, 20:36

  4. Andreas Kienast uploaded patch set 2 07/27/18, 08:46

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/27/18, 08:48

  6. TYPO3com voted on patch set 2 V +1 07/27/18, 08:52 Completed build in 06m 19s on Fri, 27 Jul, 10:52 AM Test Summary: 33488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25824

  7. Wouter Wolters voted on patch set 2 CR +1 07/27/18, 09:37

  8. Susi Moog voted on patch set 2 V +1 CR +1 07/27/18, 15:17

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 07/27/18, 17:05

  10. Andreas Kienast merged patch set 3 07/27/18, 17:05