57700[BUGFIX] Determine default language as origin correctly
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Andreas Kienast +1
-
Verified V +2
- Anja Leichsenring +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/Fixtures/tt_content-danish-language.xml+4 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php+34 −0
- typo3/sysext/backend/Tests/Functional/Domain/Repository/Localization/LocalizationRepositoryTest.php+33 −27
Review log 68
-
Nicole Hummel uploaded patch set 1 07/27/18, 11:44
-
TYPO3com voted on patch set 1 V -1 07/27/18, 11:51 Completed build in 06m 46s on Fri, 27 Jul, 01:51 PM Test Summary: 2 of 59617 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2773
-
Nicole Hummel uploaded patch set 2 07/27/18, 12:59
-
TYPO3com voted on patch set 2 V +1 07/27/18, 13:09 Completed build in 10m 36s on Fri, 27 Jul, 03:09 PM Test Summary: 59212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2774
-
Andreas Kienast voted on patch set 2 V +1 CR +1 07/27/18, 14:13
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 08/05/18, 08:43
-
Anja Leichsenring merged patch set 3 08/05/18, 08:50
-
Oliver Hader commented on patch set 3 08/20/18, 20:04
Looks good, however some more information to the commit message would have been good, e.g. "Switching from inner join to left outer join in order to retrieve default language records that cannot be joined to non-existing sys_language record with UID 0"