57701[TASK] Document integration of PharStreamWrapper
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1317
-
Oliver Hader uploaded patch set 1 07/27/18, 12:29
-
TYPO3com voted on patch set 1 V +1 07/27/18, 12:36 Completed build in 06m 35s on Fri, 27 Jul, 02:36 PM Test Summary: 33491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25837
-
Andreas Kienast commented on patch set 1 CR -1 07/27/18, 12:41
on it -
Andreas Kienast uploaded patch set 2 07/27/18, 12:43
-
Riccardo De Contardi commented on patch set 2 07/27/18, 12:44
Important-85385-IntegratePharStreamWrapper.rst:19I'd suggest: "When using Phar files in extension, the PHP magic constant `__DIR__` must be avoided and replaced..."Important-85385-IntegratePharStreamWrapper.rst:20"referenced", I guess -
Oliver Hader commented on patch set 3 07/27/18, 12:46
Published edit on patch set 2. -
Andreas Kienast voted on patch set 3 V +1 CR +1 07/27/18, 12:51
-
TYPO3com voted on patch set 2 V +1 07/27/18, 12:51 Completed build in 07m 45s on Fri, 27 Jul, 02:51 PM Test Summary: 33491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25838
-
TYPO3com voted on patch set 3 V +1 07/27/18, 12:53 Completed build in 07m 23s on Fri, 27 Jul, 02:53 PM Test Summary: 33491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25839
-
Susi Moog voted on patch set 3 V +1 CR +1 07/27/18, 15:21
-
Wouter Wolters voted on patch set 3 CR +1 07/28/18, 09:36
-
Jörg Bösche voted on patch set 3 CR +1 07/28/18, 09:52
-
Christian Kuhn commented on patch set 3 CR -1 07/29/18, 08:57
.rst files in 7.6.x that are applied to v8 too, have to be duplicated to 8.7.x. -
Christian Kuhn uploaded patch set 4 07/29/18, 08:59
-
TYPO3com voted on patch set 4 V +1 07/29/18, 09:05 Completed build in 06m 24s on Sun, 29 Jul, 11:05 AM Test Summary: 33497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25865
-
Christian Kuhn commented on patch set 4 V +2 CR +2 07/29/18, 09:09
i only copied the file around according to docs. will count in votes to previous version and merge now. -
Christian Kuhn merged patch set 5 07/29/18, 09:09