Review main Merged

57704[TASK] Update swiftmailer/swiftmailer to 5.4.10

Georg Ringer CR +2 V +2 Easy +6 −6 updated 07/29/18, 12:53

Commit message

Update swiftmailer to 5.4.10 to support TLS 1.1 / 1.2.

composer update swiftmailer/swiftmailer

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Georg Ringer uploaded patch set 1 07/27/18, 18:30

  2. TYPO3com voted on patch set 1 V +1 07/27/18, 18:38 Completed build in 07m 43s on Fri, 27 Jul, 08:38 PM Test Summary: 33491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25849

  3. Benni Mack voted on patch set 1 CR +1 07/27/18, 21:38

  4. Benni Mack commented on patch set 1 07/27/18, 21:39

    could you mention the composer command you used to modify the composer.lock?
  5. Stefan Neufeind updated the commit message in patch set 2 07/27/18, 23:01

  6. Stefan Neufeind voted on patch set 2 V +1 CR +1 07/27/18, 23:02

  7. TYPO3com voted on patch set 2 V +1 07/27/18, 23:07 Completed build in 05m 37s on Sat, 28 Jul, 01:07 AM Test Summary: 33497 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25853

  8. Stefan Neufeind commented on patch set 2 07/27/18, 23:15

    enabled tls-encryption, sent testmail to a TLS 1.2-enabled server and verified that TLS 1.2 was used on the connection
  9. Wouter Wolters voted on patch set 2 CR +1 07/28/18, 09:35

  10. Markus Klein commented on patch set 2 CR +1 07/28/18, 18:54

    I would still hope for https://review.typo3.org/55603
  11. Markus Klein commented on patch set 2 07/28/18, 18:56

    Note that with 5.4.5 the Mail Transport has been deprecated
  12. Markus Klein voted on patch set 2 V +1 07/28/18, 18:58

  13. Markus Klein commented on patch set 2 07/28/18, 18:58

    will merge that one a bit later if no one else comes first
  14. Christian Kuhn voted on patch set 2 V +2 CR +2 07/29/18, 12:53

  15. Christian Kuhn merged patch set 3 07/29/18, 12:53

  16. Christian Kuhn commented on patch set 3 07/29/18, 12:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4a211c7360b7e7e600706cbe268a1112aa9ee1c1