Review TYPO3_8-7 Abandoned

57720[BUGFIX] Set TCA override values for translation

Guido Schmechel CR 0 V 0 Easy +6 −0 updated 11/27/18, 19:58

Commit message

Now the values for the translation are also taken over
for the simple TCA types (text, input, select, check, radio)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1116

  1. Guido Schmechel uploaded patch set 1 07/29/18, 17:51

  2. TYPO3com voted on patch set 1 V -1 07/29/18, 18:00 Completed build in 08m 46s on Sun, 29 Jul, 08:00 PM Test Summary: 15 of 59615 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2785

  3. Guido Schmechel commented on patch set 1 07/29/18, 18:16

    To discuss: Is that the right way to go? And currently, there are probably still problems with multiple assignments, such as categories.
  4. Mathias Brodala commented on patch set 1 07/30/18, 08:25

    DataHandler.php:4896

    If this is the way to go you should at least use in_array() instead.
  5. Guido Schmechel rebased onto patch set 2 08/01/18, 19:49

  6. Guido Schmechel rebased onto patch set 3 08/01/18, 19:50

  7. Guido Schmechel uploaded patch set 4 08/01/18, 19:51

  8. TYPO3com commented on patch set 2 08/01/18, 19:58 Completed build in 09m 09s on Wed, 1 Aug, 09:58 PM Test Summary: 15 of 59645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2807

  9. TYPO3com commented on patch set 3 08/01/18, 20:00 Completed build in 09m 38s on Wed, 1 Aug, 10:00 PM Test Summary: 15 of 59645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2808

  10. TYPO3com voted on patch set 4 V -1 08/01/18, 20:02 Completed build in 10m 18s on Wed, 1 Aug, 10:02 PM Test Summary: 10 of 59645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2809

  11. Oliver Hader rebased onto patch set 5 10/29/18, 18:15

  12. TYPO3com voted on patch set 5 V -1 10/29/18, 18:26 Completed build in 10m 39s on Mon, 29 Oct, 07:26 PM Test Summary: 10 of 60624 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3145

  13. Oliver Hader commented on patch set 5 CR -1 10/29/18, 19:36

    Unfortunately this is too much guessing it's doing the correct thing...
  14. Oliver Hader commented on patch set 5 10/29/18, 19:36

    In general this would apply to master as well, not only to v8.7, right?
  15. Guido Schmechel commented on patch set 5 10/30/18, 15:54

    I will have a look after the T3CON. master isn't affected because of the pages_languages_overlay rewrite / refactoring.
  16. Guido Schmechel abandoned the change 11/27/18, 19:58

    Abandon for a fresh new beginning.