Review main Merged

57722[TASK] CGL: Streamline indentions in .htaccess file template

Josef Glatz CR +2 V +2 Easy +13 −8 updated 07/30/18, 11:30

Commit message

This patch adds a proper .editorconfig configuration for
.htaccess and fixes wrong existing indentions.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Mathias Brodala +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Josef Glatz uploaded patch set 1 07/29/18, 20:44

  2. TYPO3com voted on patch set 1 V +1 07/29/18, 20:51 Completed build in 07m 12s on Sun, 29 Jul, 10:51 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25887

  3. Mathias Brodala commented on patch set 1 07/30/18, 08:32

    .editorconfig:92

    I think it would make sense to cover and check all .htaccess files instead. Notice that something like this could be necessary, not sure: [{_.htaccess,.htaccess}]
  4. Josef Glatz commented on patch set 2 07/30/18, 09:06

    Published edit on patch set 1.
  5. Josef Glatz commented on patch set 1 07/30/18, 09:07

    Good idea Mathias

    .editorconfig:92 Reply

    Done
  6. Mathias Brodala voted on patch set 2 CR +1 07/30/18, 09:08

  7. TYPO3com voted on patch set 2 V +1 07/30/18, 09:13 Completed build in 06m 36s on Mon, 30 Jul, 11:13 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25900

  8. Markus Klein voted on patch set 2 V +1 CR +1 07/30/18, 09:54

  9. Wouter Wolters voted on patch set 2 V +2 CR +2 07/30/18, 11:30

  10. Wouter Wolters merged patch set 3 07/30/18, 11:30