Review main Merged

57723[TASK] Update redirect html files to HTML5

Josef Glatz CR +2 V +2 Easy +10 −10 updated 07/30/18, 09:53

Commit message

This patch updates file templates from HTML 3.2
to HTML5 markup.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
    • Jörg Bösche +1
  • Verified V +2
    • Markus Klein +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Josef Glatz uploaded patch set 1 07/29/18, 20:59

  2. TYPO3com voted on patch set 1 V +1 07/29/18, 21:06 Completed build in 06m 32s on Sun, 29 Jul, 11:06 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25888

  3. Anja Leichsenring commented on patch set 1 07/29/18, 21:18

    SessionService.php:152 Unresolved

    the <head misses the closing >
  4. Anja Leichsenring commented on patch set 1 07/29/18, 21:19

    fileadmin-temp-index.html:5 Unresolved

    the meta tag is not closed
  5. Jörg Bösche commented on patch set 2 07/29/18, 21:39

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 07/29/18, 21:48 Completed build in 08m 40s on Sun, 29 Jul, 11:48 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25890

  7. Josef Glatz commented on patch set 2 07/30/18, 03:41

    SessionService.php:152

    Thank you! I was already too tired

    fileadmin-temp-index.html:5

    Just a note on the self closing of meta tags in HTML5 context: It's absolutely not necessary but it's OK to self-close it. If it should be self closing – please also use the self-closing slash in the SessionService.php
  8. Jörg Bösche commented on patch set 3 07/30/18, 05:51

    Published edit on patch set 2.
  9. Josef Glatz voted on patch set 3 V +1 CR +1 07/30/18, 05:53

  10. TYPO3com voted on patch set 3 V +1 07/30/18, 05:57 Completed build in 06m 41s on Mon, 30 Jul, 07:57 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25896

  11. Jörg Bösche voted on patch set 3 CR +1 07/30/18, 07:59

  12. Markus Klein voted on patch set 3 V +2 CR +2 07/30/18, 09:53

  13. Markus Klein merged patch set 4 07/30/18, 09:53