Review main Merged

57725[TASK] Drop salted passwords configuration options

Christian Kuhn CR +2 V +2 Hard +64 −605 updated 07/31/18, 12:53

Commit message

In order to prepare the saltedpasswords extension to be implemented
as a library into the core directly, a series of configuration
options is dropped from the extension:

* FE.forceSalted & BE.forceSalted (default 0)
  Setting this to 1 disabled upgrading non-salted user password
  to salted passwords and denied login. The option is dropped, but
  only passwords that have been upgraded from simple md5 or plaintext
  in v8 are allowed to login and will get their password upgraded.

* FE.updatePasswd & BE.updatePasswd (default 1)
  Setting this to 0 disabled upgrading one salted password to
  another. This is dropped: Passwords will now always be upgraded
  to the currently configured hash algorithm if the currently used
  algorithm does no match the configured one.

* FE.onlyAuthService & BE.onlyAuthService (default 0)
  Setting this to 1 allowed stopping the authentication chain if
  the salted passwords did not verify a password. This setting is
  pretty useless since it can be expected that any sane authentication
  provider kicks in before the native salted passwords authentication.
  We found not a single usage of that flag in TER.

* checkConfigurationFE & checkConfigurationFE2
  & checkConfigurationBE & checkConfigurationBE2
  These configuration user function have been responsible to check
  various combinations of valid and invalid salted passwords
  combinations. This is obsolete with removing the other options and the
  deprecated rsaauth extension. An install tool preset for sane options
  and according warnings will be set up to establish better usability
  from an administrator point of view as soon as this patch is done.

The only option left is the main "saltedPWHashingMethod". This will
be transferred to an install tool preset including best option selection
during installation in a next step.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 2331

Show 36 earlier messages
  1. Christian Kuhn uploaded patch set 1 07/29/18, 21:42

  2. Christian Kuhn updated the commit message in patch set 2 07/29/18, 21:43

  3. Christian Kuhn uploaded patch set 3 07/29/18, 21:48

  4. TYPO3com voted on patch set 1 V +1 07/29/18, 21:50 Completed build in 07m 47s on Sun, 29 Jul, 11:50 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25891

  5. TYPO3com voted on patch set 2 V +1 07/29/18, 21:52 Completed build in 09m 01s on Sun, 29 Jul, 11:52 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25892

  6. TYPO3com voted on patch set 3 V +1 07/29/18, 21:55 Completed build in 06m 34s on Sun, 29 Jul, 11:55 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25893

  1. Andreas Kienast uploaded patch set 4 07/30/18, 06:44

  2. TYPO3com voted on patch set 4 V -1 07/30/18, 06:45 Completed build in 09s on Mon, 30 Jul, 08:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25897

  3. Andreas Kienast uploaded patch set 5 07/30/18, 06:45

  4. TYPO3com voted on patch set 5 V +1 07/30/18, 06:52 Completed build in 06m 38s on Mon, 30 Jul, 08:52 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25898

  5. Stephan Großberndt updated the commit message in patch set 6 07/30/18, 07:11

  6. TYPO3com voted on patch set 6 V +1 07/30/18, 07:19 Completed build in 07m 37s on Mon, 30 Jul, 09:19 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25899

  7. Andreas Kienast voted on patch set 6 V +1 CR +1 07/30/18, 08:43

  8. Wouter Wolters voted on patch set 6 CR +1 07/30/18, 11:31

  9. Georg Ringer commented on patch set 6 07/30/18, 12:14

    Important-85026-SaltedpasswordsChanges.rst:85

    i want to see a new rst as it would be completly overlooked by people upgrading from 9.3
  10. Georg Ringer voted on patch set 6 CR -1 07/30/18, 12:14

  11. Markus Klein commented on patch set 6 07/30/18, 17:30

    Important-85026-SaltedpasswordsChanges.rst:85 Reply

    For upgrades from v8 though I would argue that having stuff in one file makes things easier. I do not have a strong opinion, but looking at the number of "affected people" I would say that the few souls using v9.3 now in comparison to the number of future upgrades from v8 is neglectable. Besides that this does not break anything.
  12. Markus Klein commented on patch set 6 07/30/18, 21:44

    Important-85026-SaltedpasswordsChanges.rst:111

    TYPO3

    Important-85026-SaltedpasswordsChanges.rst:112

    additional
  13. Markus Klein commented on patch set 6 07/30/18, 22:12

    locallang.xlf:33

    did you check all labels one by one whether they are really unused?
  14. Christian Kuhn commented on patch set 6 07/31/18, 08:07

    locallang.xlf:33 Reply

    yes.
  15. Christian Kuhn uploaded patch set 7 07/31/18, 10:51

  16. Markus Klein commented on patch set 8 07/31/18, 10:59

    Published edit on patch set 7.
  17. TYPO3com voted on patch set 7 V +1 07/31/18, 11:01 Completed build in 09m 08s on Tue, 31 Jul, 01:01 PM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25929

  18. TYPO3com voted on patch set 8 V +1 07/31/18, 11:08 Completed build in 08m 45s on Tue, 31 Jul, 01:08 PM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25930

  19. Markus Klein voted on patch set 8 V +1 CR +1 07/31/18, 11:51

  20. Andreas Kienast voted on patch set 8 V +2 CR +2 07/31/18, 11:54

  21. Andreas Kienast merged patch set 9 07/31/18, 11:54

  22. Stephan Großberndt commented on patch set 9 07/31/18, 11:57

    Why and how was I removed as a reviewer from this patch?
  23. Stephan Großberndt commented on patch set 7 07/31/18, 12:08

    Important-85026-SaltedpasswordsChanges.rst:16

    timeline

    Important-85026-SaltedpasswordsChanges.rst:33

    non-existing

    Important-85026-SaltedpasswordsChanges.rst:56

    delete this

    Important-85026-SaltedpasswordsChanges.rst:61

    remove ,

    Important-85683-DoppedSaltedpasswordOptions.rst:12

    has

    Important-85683-DoppedSaltedpasswordOptions.rst:15

    remove ,

    Important-85683-DoppedSaltedpasswordOptions.rst:25

    remove ,

    Important-85683-DoppedSaltedpasswordOptions.rst:26

    This option

    Important-85683-DoppedSaltedpasswordOptions.rst:26

    avoid updating

    Important-85683-DoppedSaltedpasswordOptions.rst:26

    hash

    Important-85683-DoppedSaltedpasswordOptions.rst:32

    remove ,

    Important-85683-DoppedSaltedpasswordOptions.rst:34

    TYPO3

    Important-85683-DoppedSaltedpasswordOptions.rst:35

    additional

    Important-85683-DoppedSaltedpasswordOptions.rst:36

    . Action is
  24. Markus Klein commented on patch set 9 07/31/18, 12:48

    > Why and how was I removed as a reviewer from this patch? Sorry, I've no clue. No history entry for that
  25. Christian Kuhn commented on patch set 9 07/31/18, 12:53

    i will change the .rst in a next patch.