57725[TASK] Drop salted passwords configuration options
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Markus Klein +1
-
Verified V +2
- Andreas Kienast +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+3 −4
- typo3/sysext/core/Documentation/Changelog/master/Important-85683-DoppedSaltedpasswordOptions.rst10new+40 −0
- typo3/sysext/core/Tests/Unit/Configuration/ExtensionConfigurationTest.php+6 −6
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+0 −56
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+0 −296
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php+0 −3
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+15 −23
- typo3/sysext/saltedpasswords/Documentation/Configuration/Index.rst+0 −61
- typo3/sysext/saltedpasswords/Resources/Private/Language/locallang.xlf2+0 −90
- typo3/sysext/saltedpasswords/Resources/Private/Language/locallang_em.xlf+0 −30
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+0 −6
- typo3/sysext/saltedpasswords/ext_conf_template.txt+0 −30
Review log 2331
Show 36 earlier messages
-
Christian Kuhn uploaded patch set 1 07/29/18, 21:42
-
Christian Kuhn updated the commit message in patch set 2 07/29/18, 21:43
-
Christian Kuhn uploaded patch set 3 07/29/18, 21:48
-
TYPO3com voted on patch set 1 V +1 07/29/18, 21:50 Completed build in 07m 47s on Sun, 29 Jul, 11:50 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25891
-
TYPO3com voted on patch set 2 V +1 07/29/18, 21:52 Completed build in 09m 01s on Sun, 29 Jul, 11:52 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25892
-
TYPO3com voted on patch set 3 V +1 07/29/18, 21:55 Completed build in 06m 34s on Sun, 29 Jul, 11:55 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25893
-
Andreas Kienast uploaded patch set 4 07/30/18, 06:44
-
TYPO3com voted on patch set 4 V -1 07/30/18, 06:45 Completed build in 09s on Mon, 30 Jul, 08:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25897
-
Andreas Kienast uploaded patch set 5 07/30/18, 06:45
-
TYPO3com voted on patch set 5 V +1 07/30/18, 06:52 Completed build in 06m 38s on Mon, 30 Jul, 08:52 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25898
-
Stephan Großberndt updated the commit message in patch set 6 07/30/18, 07:11
-
TYPO3com voted on patch set 6 V +1 07/30/18, 07:19 Completed build in 07m 37s on Mon, 30 Jul, 09:19 AM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25899
-
Andreas Kienast voted on patch set 6 V +1 CR +1 07/30/18, 08:43
-
Wouter Wolters voted on patch set 6 CR +1 07/30/18, 11:31
-
Georg Ringer commented on patch set 6 07/30/18, 12:14
-
Georg Ringer voted on patch set 6 CR -1 07/30/18, 12:14
-
Markus Klein commented on patch set 6 07/30/18, 17:30
Important-85026-SaltedpasswordsChanges.rst:85ReplyFor upgrades from v8 though I would argue that having stuff in one file makes things easier. I do not have a strong opinion, but looking at the number of "affected people" I would say that the few souls using v9.3 now in comparison to the number of future upgrades from v8 is neglectable. Besides that this does not break anything. -
Markus Klein commented on patch set 6 07/30/18, 21:44
Important-85026-SaltedpasswordsChanges.rst:111TYPO3Important-85026-SaltedpasswordsChanges.rst:112additional -
Markus Klein commented on patch set 6 07/30/18, 22:12
locallang.xlf:33did you check all labels one by one whether they are really unused? -
Christian Kuhn commented on patch set 6 07/31/18, 08:07
locallang.xlf:33Replyyes. -
Christian Kuhn uploaded patch set 7 07/31/18, 10:51
-
Markus Klein commented on patch set 8 07/31/18, 10:59
Published edit on patch set 7. -
TYPO3com voted on patch set 7 V +1 07/31/18, 11:01 Completed build in 09m 08s on Tue, 31 Jul, 01:01 PM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25929
-
TYPO3com voted on patch set 8 V +1 07/31/18, 11:08 Completed build in 08m 45s on Tue, 31 Jul, 01:08 PM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25930
-
Markus Klein voted on patch set 8 V +1 CR +1 07/31/18, 11:51
-
Andreas Kienast voted on patch set 8 V +2 CR +2 07/31/18, 11:54
-
Andreas Kienast merged patch set 9 07/31/18, 11:54
-
Stephan Großberndt commented on patch set 9 07/31/18, 11:57
Why and how was I removed as a reviewer from this patch? -
Stephan Großberndt commented on patch set 7 07/31/18, 12:08
Important-85026-SaltedpasswordsChanges.rst:16timelineImportant-85026-SaltedpasswordsChanges.rst:33non-existingImportant-85026-SaltedpasswordsChanges.rst:56delete thisImportant-85026-SaltedpasswordsChanges.rst:61remove ,Important-85683-DoppedSaltedpasswordOptions.rst:12hasImportant-85683-DoppedSaltedpasswordOptions.rst:15remove ,Important-85683-DoppedSaltedpasswordOptions.rst:25remove ,Important-85683-DoppedSaltedpasswordOptions.rst:26This optionImportant-85683-DoppedSaltedpasswordOptions.rst:26avoid updatingImportant-85683-DoppedSaltedpasswordOptions.rst:26hashImportant-85683-DoppedSaltedpasswordOptions.rst:32remove ,Important-85683-DoppedSaltedpasswordOptions.rst:34TYPO3Important-85683-DoppedSaltedpasswordOptions.rst:35additionalImportant-85683-DoppedSaltedpasswordOptions.rst:36. Action is -
Markus Klein commented on patch set 9 07/31/18, 12:48
> Why and how was I removed as a reviewer from this patch? Sorry, I've no clue. No history entry for that -
Christian Kuhn commented on patch set 9 07/31/18, 12:53
i will change the .rst in a next patch.
Important-85026-SaltedpasswordsChanges.rst:85