Review 9.3 Merged

57727[BUGFIX] Avoid PHP warning when using Phar archive with open_basedir

Oliver Hader CR +2 V +2 Easy +1 −1 updated 07/30/18, 14:53

Commit message

Including files from Phar archives (e.g. "phar://file.phar/autoload.php")
does not work properly with having PHP setting open_basedir defined. The
reason for that is, that TYPO3's custom PharStreamWrapper tries to find
the appropriate base Phar file using file_exists() calls internally. In
case those files are not part of the open_basedir restriction - which is
the case for everything prefixed with the "phar://" scheme - a PHP
warning is shown.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 3

  1. Oliver Hader commented on patch set 1 07/30/18, 14:51

    Cherry Picked from branch master.
  2. Oliver Hader voted on patch set 1 V +2 CR +2 07/30/18, 14:53

  3. Oliver Hader merged patch set 2 07/30/18, 14:53