Review main Merged

57730[BUGFIX] Access global TYPO3 object correctly

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 07/30/18, 18:48

Commit message

The setting `TYPO3.settings.ShowItem.moduleUrl` does not exist in the
local scope in some cases. The `TYPO3` object of the global (`top`)
scope is now used instead.

Review

  • Code review CR +2
    • Markus Klein +2
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Andreas Kienast uploaded patch set 1 07/30/18, 18:03

  2. Susi Moog voted on patch set 1 V +1 CR +1 07/30/18, 18:09

  3. TYPO3com voted on patch set 1 V +1 07/30/18, 18:10 Completed build in 06m 43s on Mon, 30 Jul, 08:10 PM Test Summary: 33575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25912

  4. Markus Klein voted on patch set 1 V +2 CR +2 07/30/18, 18:48

  5. Markus Klein merged patch set 2 07/30/18, 18:48