57735[FEATURE] Add path where reference records are located to record info
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Tymoteusz Motylewski +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Tymoteusz Motylewski +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −0
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html1+4 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-85691-ShowPagePathForReferencesInRecordInfo.rstnew+20 −0
Review log 2026
Show 1 earlier messages
-
Kevin Ditscheid uploaded patch set 1 07/31/18, 07:54
-
Kevin Ditscheid updated the commit message in patch set 2 07/31/18, 07:55
-
TYPO3com voted on patch set 1 V +1 07/31/18, 08:03 Completed build in 09m 24s on Tue, 31 Jul, 10:03 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25924
-
TYPO3com voted on patch set 2 V +1 07/31/18, 08:10 Completed build in 09m 56s on Tue, 31 Jul, 10:10 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25925
-
Kevin Ditscheid updated the commit message in patch set 3 07/31/18, 08:14
-
Kevin Ditscheid updated the commit message in patch set 4 07/31/18, 08:33
-
TYPO3com voted on patch set 3 V +1 07/31/18, 08:34 Completed build in 18m 36s on Tue, 31 Jul, 10:34 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25927
-
TYPO3com voted on patch set 4 V +1 07/31/18, 08:51 Completed build in 15m 04s on Tue, 31 Jul, 10:51 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25928
-
Tymoteusz Motylewski commented on patch set 4 CR -1 07/31/18, 12:25
Nice feature! Just few remarks 1. please target patch to master only 2. please add an rst file (you can generate one using https://forger.typo3.com/utility/rst ) -
Franz Kugelmann commented on patch set 4 V +1 07/31/18, 13:02
Thanks Kevin! Works as expected. -
Kevin Ditscheid uploaded patch set 5 07/31/18, 13:17
-
Kevin Ditscheid commented on patch set 5 07/31/18, 13:18
Hope this will be sufficient as RST for you ;) -
TYPO3com voted on patch set 5 V +1 07/31/18, 13:26 Completed build in 08m 28s on Tue, 31 Jul, 03:26 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25935
-
Josef Glatz commented on patch set 5 CR -1 07/31/18, 14:18
ElementInformation.html:157Idea: we could use CSS ellipsis here only. With that it's still possible to copy the whole string by double click and cmd+v / strg+v. According to caniuse, it's supported by "every" browser beginning with IE11. I would say it depends on which browsers we must support. -
Kevin Ditscheid commented on patch set 5 07/31/18, 14:44
> (1 comment) Is there a class already we could use or do we need to introduce extra CSS? I do not know the place to properly drop this CSS if needed, maybe someone can guide me -
Riccardo De Contardi commented on patch set 5 V +1 07/31/18, 20:13
works fine. When the path becomes very long, an horizontal bar appears; Maybe the text could be truncated earlier (the title attr will show it fully anyway) -
Josef Glatz commented on patch set 5 08/01/18, 04:13
> > (1 comment) > > Is there a class already we could use or do we need to introduce > extra CSS? I do not know the place to properly drop this CSS if > needed, maybe someone can guide me I will take a look today if there is something we can use and re-check the browser support -
Kevin Ditscheid uploaded patch set 6 08/10/18, 12:19
-
TYPO3com voted on patch set 6 V +1 08/10/18, 12:28 Completed build in 08m 51s on Fri, 10 Aug, 02:28 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26358
-
Tymoteusz Motylewski commented on patch set 6 08/10/18, 13:01
Hi Kevin, The sass is most probably located in Build/Resources/Public/Sass, tnen you can build css using yarn, see: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/SetupTypo3.html?highlight=css -
Kevin Ditscheid commented on patch set 6 08/10/18, 13:03
> Hi Kevin, > The sass is most probably located in Build/Resources/Public/Sass, > tnen you can build css using yarn, see: > https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/SetupTypo3.html?highlight=css Question is, if the class I found would be sufficient, because it's located in a table related sass file -
Tymoteusz Motylewski commented on patch set 6 08/10/18, 13:07
don't know that, please ask in the #typo3-cms-coredev slack channel. -
Andreas Kienast voted on patch set 6 CR +1 08/14/18, 07:43
-
Tymoteusz Motylewski voted on patch set 6 V +1 CR +1 08/14/18, 09:32
-
Christian Kuhn voted on patch set 6 V +2 CR +2 08/14/18, 11:13
-
Christian Kuhn merged patch set 7 08/14/18, 11:13