Review main Merged

57735[FEATURE] Add path where reference records are located to record info

Kevin Ditscheid CR +2 V +2 Easy +26 −0 updated 08/14/18, 11:13

Commit message

This change is enhancing the reference infos of records by adding the
path in the pagetree to the table of record references. This path is
similar to the path in the record edit view on the top right corner

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2026

Show 1 earlier messages
  1. Kevin Ditscheid uploaded patch set 1 07/31/18, 07:54

  1. Kevin Ditscheid updated the commit message in patch set 2 07/31/18, 07:55

  2. TYPO3com voted on patch set 1 V +1 07/31/18, 08:03 Completed build in 09m 24s on Tue, 31 Jul, 10:03 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25924

  3. TYPO3com voted on patch set 2 V +1 07/31/18, 08:10 Completed build in 09m 56s on Tue, 31 Jul, 10:10 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25925

  4. Kevin Ditscheid updated the commit message in patch set 3 07/31/18, 08:14

  5. Kevin Ditscheid updated the commit message in patch set 4 07/31/18, 08:33

  6. TYPO3com voted on patch set 3 V +1 07/31/18, 08:34 Completed build in 18m 36s on Tue, 31 Jul, 10:34 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25927

  7. TYPO3com voted on patch set 4 V +1 07/31/18, 08:51 Completed build in 15m 04s on Tue, 31 Jul, 10:51 AM Test Summary: 33620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25928

  8. Tymoteusz Motylewski commented on patch set 4 CR -1 07/31/18, 12:25

    Nice feature! Just few remarks 1. please target patch to master only 2. please add an rst file (you can generate one using https://forger.typo3.com/utility/rst )
  9. Franz Kugelmann commented on patch set 4 V +1 07/31/18, 13:02

    Thanks Kevin! Works as expected.
  10. Kevin Ditscheid uploaded patch set 5 07/31/18, 13:17

  11. Kevin Ditscheid commented on patch set 5 07/31/18, 13:18

    Hope this will be sufficient as RST for you ;)
  12. TYPO3com voted on patch set 5 V +1 07/31/18, 13:26 Completed build in 08m 28s on Tue, 31 Jul, 03:26 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25935

  13. Josef Glatz commented on patch set 5 CR -1 07/31/18, 14:18

    ElementInformation.html:157

    Idea: we could use CSS ellipsis here only. With that it's still possible to copy the whole string by double click and cmd+v / strg+v. According to caniuse, it's supported by "every" browser beginning with IE11. I would say it depends on which browsers we must support.
  14. Kevin Ditscheid commented on patch set 5 07/31/18, 14:44

    > (1 comment) Is there a class already we could use or do we need to introduce extra CSS? I do not know the place to properly drop this CSS if needed, maybe someone can guide me
  15. Riccardo De Contardi commented on patch set 5 V +1 07/31/18, 20:13

    works fine. When the path becomes very long, an horizontal bar appears; Maybe the text could be truncated earlier (the title attr will show it fully anyway)
  16. Josef Glatz commented on patch set 5 08/01/18, 04:13

    > > (1 comment) > > Is there a class already we could use or do we need to introduce > extra CSS? I do not know the place to properly drop this CSS if > needed, maybe someone can guide me I will take a look today if there is something we can use and re-check the browser support
  17. Kevin Ditscheid uploaded patch set 6 08/10/18, 12:19

  18. TYPO3com voted on patch set 6 V +1 08/10/18, 12:28 Completed build in 08m 51s on Fri, 10 Aug, 02:28 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26358

  19. Tymoteusz Motylewski commented on patch set 6 08/10/18, 13:01

    Hi Kevin, The sass is most probably located in Build/Resources/Public/Sass, tnen you can build css using yarn, see: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/SetupTypo3.html?highlight=css
  20. Kevin Ditscheid commented on patch set 6 08/10/18, 13:03

    > Hi Kevin, > The sass is most probably located in Build/Resources/Public/Sass, > tnen you can build css using yarn, see: > https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/SetupTypo3.html?highlight=css Question is, if the class I found would be sufficient, because it's located in a table related sass file
  21. Tymoteusz Motylewski commented on patch set 6 08/10/18, 13:07

    don't know that, please ask in the #typo3-cms-coredev slack channel.
  22. Andreas Kienast voted on patch set 6 CR +1 08/14/18, 07:43

  23. Tymoteusz Motylewski voted on patch set 6 V +1 CR +1 08/14/18, 09:32

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 08/14/18, 11:13

  25. Christian Kuhn merged patch set 7 08/14/18, 11:13