Review main Merged

57746[FEATURE] Add TCA 'saltedPassword' eval for type=input

Christian Kuhn CR +2 V +2 Hard +115 −236 updated 08/01/18, 07:25

Commit message

The salted passwords extension did register a custom
field evaluation to hash a given password when editing users
in the backend through FormEngine.
This is now turned into a general eval 'saltedPassword'
and handled in the DataHandler directly. Note the existing
eval 'password' is not extended since 'password' eval
changes the display part to show '****', which should be
kept seperated from the salt evaluation.
The "Evaluation" classes are dropped directly without
substitution since they are totally saltedpasswords internal
and don't make sense to be used externally.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1014

  1. Christian Kuhn uploaded patch set 1 07/31/18, 14:28

  2. TYPO3com voted on patch set 1 V -1 07/31/18, 14:37 Completed build in 08m 33s on Tue, 31 Jul, 04:37 PM Test Summary: 9 of 33854 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25937

  3. Christian Kuhn uploaded patch set 2 07/31/18, 16:15

  4. TYPO3com voted on patch set 2 V -1 07/31/18, 16:15 Completed build in 11s on Tue, 31 Jul, 06:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25938

  5. Christian Kuhn uploaded patch set 3 07/31/18, 16:16

  6. TYPO3com voted on patch set 3 V +1 07/31/18, 16:25 Completed build in 08m 25s on Tue, 31 Jul, 06:25 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25939

  7. Andreas Kienast updated the commit message in patch set 4 07/31/18, 17:59

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 07/31/18, 17:59

  9. Wouter Wolters voted on patch set 4 CR +1 07/31/18, 18:02

  10. TYPO3com voted on patch set 4 V +1 07/31/18, 18:07 Completed build in 08m 07s on Tue, 31 Jul, 08:07 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25941

  11. Wouter Wolters voted on patch set 4 V +2 CR +2 07/31/18, 18:17

  12. Wouter Wolters merged patch set 5 07/31/18, 18:17

  13. Oliver Hader commented on patch set 5 08/01/18, 07:08

    This is at the same time a breaking change, isn't it? * custom extension configurations storing a salted password elsewhere (my_custom_model.password) has to be upgraded to the new eval identifier * custom evaluations (those that implement a custom handling/hashing mechanism using callbacks) now would have to remove the new eval identifier
  14. Christian Kuhn commented on patch set 5 08/01/18, 07:25

    i don't think that's heavily breaking, olly: saltedpasswords is a mandatory extension for quite some versions already and it hardcoded itself into the eval list into fe_users and be_users with the two classes tailored for this.