57746[FEATURE] Add TCA 'saltedPassword' eval for type=input
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+29 −3
- typo3/sysext/core/Configuration/TCA/be_users.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-85698-NewTypeinputEvalSaltedPassword.rstnew+31 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-85683-DoppedSaltedpasswordOptions.rst+6 −6
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+44 −4
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+3 −3
- typo3/sysext/saltedpasswords/Classes/Evaluation/BackendEvaluator.phpdeleted+0 −29
- typo3/sysext/saltedpasswords/Classes/Evaluation/Evaluator.phpdeleted+0 −63
- typo3/sysext/saltedpasswords/Classes/Evaluation/FrontendEvaluator.phpdeleted+0 −29
- typo3/sysext/saltedpasswords/Configuration/TCA/Overrides/be_users.phpdeleted+0 −15
- typo3/sysext/saltedpasswords/Configuration/TCA/Overrides/fe_users.phpdeleted+0 −13
- typo3/sysext/saltedpasswords/Tests/Unit/Evaluation/EvaluatorTest.phpdeleted+0 −64
- typo3/sysext/saltedpasswords/ext_localconf.php+0 −5
Review log 1014
-
Christian Kuhn uploaded patch set 1 07/31/18, 14:28
-
TYPO3com voted on patch set 1 V -1 07/31/18, 14:37 Completed build in 08m 33s on Tue, 31 Jul, 04:37 PM Test Summary: 9 of 33854 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25937
-
Christian Kuhn uploaded patch set 2 07/31/18, 16:15
-
TYPO3com voted on patch set 2 V -1 07/31/18, 16:15 Completed build in 11s on Tue, 31 Jul, 06:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25938
-
Christian Kuhn uploaded patch set 3 07/31/18, 16:16
-
TYPO3com voted on patch set 3 V +1 07/31/18, 16:25 Completed build in 08m 25s on Tue, 31 Jul, 06:25 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25939
-
Andreas Kienast updated the commit message in patch set 4 07/31/18, 17:59
-
Andreas Kienast voted on patch set 4 V +1 CR +1 07/31/18, 17:59
-
Wouter Wolters voted on patch set 4 CR +1 07/31/18, 18:02
-
TYPO3com voted on patch set 4 V +1 07/31/18, 18:07 Completed build in 08m 07s on Tue, 31 Jul, 08:07 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25941
-
Wouter Wolters voted on patch set 4 V +2 CR +2 07/31/18, 18:17
-
Wouter Wolters merged patch set 5 07/31/18, 18:17
-
Oliver Hader commented on patch set 5 08/01/18, 07:08
This is at the same time a breaking change, isn't it? * custom extension configurations storing a salted password elsewhere (my_custom_model.password) has to be upgraded to the new eval identifier * custom evaluations (those that implement a custom handling/hashing mechanism using callbacks) now would have to remove the new eval identifier -
Christian Kuhn commented on patch set 5 08/01/18, 07:25
i don't think that's heavily breaking, olly: saltedpasswords is a mandatory extension for quite some versions already and it hardcoded itself into the eval list into fe_users and be_users with the two classes tailored for this.