Review main Merged

57750[TASK] Deprecate methods in ModuleTemplate

Wouter Wolters CR +2 V +2 Normal +53 −1 updated 08/02/18, 11:07

Commit message

Two methods are marked as deprecated in the class ModuleTemplate.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Benni Mack +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1013

  1. Wouter Wolters uploaded patch set 1 07/31/18, 19:26

  2. TYPO3com voted on patch set 1 V +1 07/31/18, 19:32 Completed build in 06m 28s on Tue, 31 Jul, 09:32 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25950

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/01/18, 15:42

  4. Benni Mack commented on patch set 1 08/01/18, 15:45

    Interesting enough this class is marked as internal ;)
  5. Nicole Hummel commented on patch set 2 08/01/18, 16:08

    Published edit on patch set 1.
  6. Nicole Hummel voted on patch set 2 V +1 CR +1 08/01/18, 16:08

  7. Nicole Hummel commented on patch set 2 08/01/18, 16:10

    ModuleTemplate.php:490

    Maybe we should add @see \TYPO3\CMS\Core\Page\PageRenderer::addJsFile
  8. TYPO3com voted on patch set 2 V +1 08/01/18, 16:16 Completed build in 07m 06s on Wed, 1 Aug, 06:16 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25966

  9. Wouter Wolters commented on patch set 3 08/02/18, 08:19

    Published edit on patch set 2.
  10. Benni Mack voted on patch set 3 V +1 CR +1 08/02/18, 08:26

  11. TYPO3com voted on patch set 3 V +1 08/02/18, 08:29 Completed build in 10m 34s on Thu, 2 Aug, 10:29 AM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26007

  12. Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 08/02/18, 11:07

  13. Tymoteusz Motylewski merged patch set 4 08/02/18, 11:07