Review main Merged

57754[BUGFIX] Streamline deprecation messages

Benni Mack CR +2 V +2 Normal +44 −44 updated 08/01/18, 12:49

Commit message

Some usages of trigger_error() used \E_USER_DEPRECATED or no 2nd parameter
(which falls back to E_USER_NOTICE) which resulted in some weird issues
with opcache fatal PHP errors.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Sattler +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 45

  1. Benni Mack uploaded patch set 1 08/01/18, 12:36

  2. TYPO3com voted on patch set 1 V +1 08/01/18, 12:44 Completed build in 07m 27s on Wed, 1 Aug, 02:44 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25958

  3. Daniel Sattler voted on patch set 1 V +1 CR +1 08/01/18, 12:44

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 08/01/18, 12:49

  5. Wouter Wolters merged patch set 2 08/01/18, 12:49