Review main Merged

57757[TASK] Clean up tests from Context API refactoring

Benni Mack CR +2 V +2 Normal +10 −66 updated 08/01/18, 19:18

Commit message

Due to the Context API a lot less mocking needs to be done, and tests can be cleaned up.

On top, cObject receives a TSFE object as first parameter as DI, which can be used in
the code instead of global variables.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Nicole Hummel +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 810

  1. Benni Mack uploaded patch set 1 08/01/18, 15:24

  2. TYPO3com voted on patch set 1 V +1 08/01/18, 15:31 Completed build in 06m 54s on Wed, 1 Aug, 05:31 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25963

  3. Nicole Hummel commented on patch set 1 08/01/18, 16:21

    AbstractTypolinkBuilderTest.php:62

    Do we still need a mock here?
  4. Benni Mack uploaded patch set 2 08/01/18, 17:04

  5. Benni Mack commented on patch set 1 08/01/18, 17:04

    AbstractTypolinkBuilderTest.php:62 Reply

    nope. thanks
  6. TYPO3com voted on patch set 2 V +1 08/01/18, 17:11 Completed build in 07m 30s on Wed, 1 Aug, 07:11 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25969

  7. Nicole Hummel voted on patch set 2 CR +1 08/01/18, 17:36

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/01/18, 19:15

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 08/01/18, 19:18

  10. Andreas Kienast merged patch set 3 08/01/18, 19:18