Review main Merged

57758[TASK] Separate sending from gathering HTTP headers

Benni Mack CR +2 V +2 Normal +103 −47 updated 08/01/18, 19:13

Commit message

In order to streamline HTTP response output, the list compiling of
headers sent to the browser is separated from the actual sending
(PHP call "header()").

This is a pre-patch to allow further refactorings for
better PSR-7 support.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Benni Mack uploaded patch set 1 08/01/18, 15:45

  2. Benni Mack updated the commit message in patch set 2 08/01/18, 15:50

  3. TYPO3com voted on patch set 1 V +1 08/01/18, 15:51 Completed build in 06m 21s on Wed, 1 Aug, 05:51 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25964

  4. TYPO3com voted on patch set 2 V -1 08/01/18, 15:56 Completed build in 05m 56s on Wed, 1 Aug, 05:56 PM Test Summary: 33576 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25965

  5. TYPO3com voted on patch set 2 V +1 08/01/18, 15:57 Completed build in 13m 14s on Wed, 1 Aug, 05:57 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25965

  6. Nicole Hummel voted on patch set 2 CR +1 08/01/18, 16:00

  7. Andreas Kienast voted on patch set 2 CR +1 08/01/18, 17:29

  8. Markus Klein commented on patch set 2 08/01/18, 18:28

    AbstractUserAuthentication.php:471

    TypoScriptFrontendController.php:4036

    one space too much
  9. Markus Klein commented on patch set 3 08/01/18, 18:28

    Published edit on patch set 2.
  10. Markus Klein voted on patch set 3 CR +1 08/01/18, 18:28

  11. Markus Klein voted on patch set 3 V +1 08/01/18, 18:31

  12. TYPO3com voted on patch set 3 V +1 08/01/18, 18:36 Completed build in 07m 24s on Wed, 1 Aug, 08:36 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25972

  13. Andreas Kienast voted on patch set 3 CR +1 08/01/18, 18:58

  14. Nicole Hummel voted on patch set 3 CR +1 08/01/18, 18:59

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 08/01/18, 19:13

  16. Christian Kuhn merged patch set 4 08/01/18, 19:13