Review main Merged

57766[TASK] Remove enm1989/chromedriver dependency

Christian Kuhn CR +2 V +2 Normal +1 −60 updated 09/02/18, 14:03

Commit message

We don't need chromedriver as dev dependency anymore since
the acceptance tests use selenium via docker nowadays.
Executing ac tests locally will be simplified with another
patch, but using chromedriver is ditched already since
that does not lead to stable tests.

composer remove --dev enm1989/chromedriver

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
  • Verified V +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1520

  1. Christian Kuhn uploaded patch set 1 08/01/18, 20:44

  2. Christian Kuhn updated the commit message in patch set 2 08/01/18, 20:45

  3. Christian Kuhn voted on patch set 2 CR -2 08/01/18, 20:47

  4. Christian Kuhn uploaded patch set 3 08/01/18, 20:50

  5. Christian Kuhn commented on patch set 3 08/01/18, 20:51

    will keep that pending for a while until i can come up with a decent docker-compose.yml to execute tests locally.
  6. TYPO3com voted on patch set 1 V +1 08/01/18, 20:53 Completed build in 08m 59s on Wed, 1 Aug, 10:53 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25989

  7. TYPO3com voted on patch set 2 V +1 08/01/18, 20:55 Completed build in 10m 01s on Wed, 1 Aug, 10:55 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25990

  8. TYPO3com voted on patch set 3 V +1 08/01/18, 21:00 Completed build in 08m 41s on Wed, 1 Aug, 11:00 PM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25993

  9. Christian Kuhn uploaded patch set 4 09/02/18, 13:06

  10. Christian Kuhn voted on patch set 4 CR 0 09/02/18, 13:06

  11. TYPO3com voted on patch set 4 V +1 09/02/18, 13:14 Completed build in 07m 40s on Sun, 2 Sep, 03:14 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27556

  12. Christian Kuhn commented on patch set 4 09/02/18, 13:34

    i'd say we should remove that now, even if the new way to run tests is not fully documented.
  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/02/18, 13:34

  14. Christian Kuhn voted on patch set 4 CR -2 09/02/18, 13:48

  15. Christian Kuhn uploaded patch set 5 09/02/18, 13:49

  16. Christian Kuhn voted on patch set 5 CR 0 09/02/18, 13:49

  17. Anja Leichsenring voted on patch set 5 V +1 CR +1 09/02/18, 13:50

  18. TYPO3com voted on patch set 5 V +1 09/02/18, 13:58 Completed build in 09m 24s on Sun, 2 Sep, 03:58 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27558

  19. Andreas Wolf voted on patch set 5 V +2 CR +2 09/02/18, 14:03

  20. Andreas Wolf merged patch set 6 09/02/18, 14:03