57770[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Anja Leichsenring +1
-
Verified V +2
- Wouter Wolters +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+7 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php4+14 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85801-GeneralUtilityexplodeUrl2Array-2ndMethodArgument.rstnew+36 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −13
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php+24 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+5 −3
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+3 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+6 −4
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedStaticMatcher.php+6 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+2 −1
Review log 1723
-
Benni Mack uploaded patch set 1 08/02/18, 08:07
-
TYPO3com voted on patch set 1 V -1 08/02/18, 08:15 Completed build in 07m 49s on Thu, 2 Aug, 10:15 AM Test Summary: 3 of 33846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26005
-
Benni Mack uploaded patch set 2 08/02/18, 08:18
-
TYPO3com voted on patch set 2 V -1 08/02/18, 08:29 Completed build in 10m 21s on Thu, 2 Aug, 10:29 AM Test Summary: 3 of 33846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26006
-
Benni Mack uploaded patch set 3 08/10/18, 08:18
-
TYPO3com voted on patch set 3 V -1 08/10/18, 08:25 Completed build in 06m 44s on Fri, 10 Aug, 10:25 AM Test Summary: 3 of 33838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26335
-
Benni Mack uploaded patch set 4 08/10/18, 09:20
-
TYPO3com voted on patch set 4 V +1 08/10/18, 09:27 Completed build in 06m 32s on Fri, 10 Aug, 11:27 AM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26340
-
Benni Mack updated the commit message in patch set 5 08/10/18, 09:31
-
TYPO3com voted on patch set 5 V +1 08/10/18, 09:40 Completed build in 09m 22s on Fri, 10 Aug, 11:40 AM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26342
-
Wouter Wolters commented on patch set 5 08/10/18, 09:42
ReplaceFileController.php:172same here -
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/10/18, 09:46
-
Wouter Wolters commented on patch set 5 CR -1 08/10/18, 10:00
on it -
Wouter Wolters uploaded patch set 6 08/10/18, 10:03
-
Wouter Wolters voted on patch set 6 V +1 CR +1 08/10/18, 10:03
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 08/10/18, 10:06
-
Mathias Brodala commented on patch set 6 08/10/18, 10:08
GeneralUtility.php:1190Shouldn't this also check for `null` too? -
Mathias Brodala commented on patch set 6 08/10/18, 10:09
GeneralUtility.php:1190ReplyOtherwise passing `false` will prevent the error being triggered. -
TYPO3com voted on patch set 6 V +1 08/10/18, 10:11 Completed build in 08m 28s on Fri, 10 Aug, 12:11 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26346
-
Wouter Wolters commented on patch set 6 08/10/18, 10:17
GeneralUtility.php:1190ReplyFalse is catched in the else part IMO -
Mathias Brodala commented on patch set 6 08/10/18, 10:28
GeneralUtility.php:1190ReplyIndeed, sorry for the noise. ;-) -
Wouter Wolters voted on patch set 6 V +2 CR +2 08/10/18, 10:30
-
Wouter Wolters merged patch set 7 08/10/18, 10:30
RenameFileController.php:162