Review main Merged

57770[TASK] Deprecate 2nd argument of GeneralUtility::explodeUrl2Array

Benni Mack CR +2 V +2 Normal +112 −31 updated 02/20/19, 21:26

Commit message

Calling `GeneralUtility::explodeUrl2Array` with a second
parameter "true" can be simplified by using PHP's
native parse_str() method directly.

The second parameter is then deprecated.

All occurrences are replaced with "parse_str()" where
the second parameter was set to true.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1723

  1. Benni Mack uploaded patch set 1 08/02/18, 08:07

  2. TYPO3com voted on patch set 1 V -1 08/02/18, 08:15 Completed build in 07m 49s on Thu, 2 Aug, 10:15 AM Test Summary: 3 of 33846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26005

  3. Benni Mack uploaded patch set 2 08/02/18, 08:18

  4. TYPO3com voted on patch set 2 V -1 08/02/18, 08:29 Completed build in 10m 21s on Thu, 2 Aug, 10:29 AM Test Summary: 3 of 33846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26006

  5. Benni Mack uploaded patch set 3 08/10/18, 08:18

  6. TYPO3com voted on patch set 3 V -1 08/10/18, 08:25 Completed build in 06m 44s on Fri, 10 Aug, 10:25 AM Test Summary: 3 of 33838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26335

  7. Benni Mack uploaded patch set 4 08/10/18, 09:20

  8. TYPO3com voted on patch set 4 V +1 08/10/18, 09:27 Completed build in 06m 32s on Fri, 10 Aug, 11:27 AM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26340

  9. Benni Mack updated the commit message in patch set 5 08/10/18, 09:31

  10. TYPO3com voted on patch set 5 V +1 08/10/18, 09:40 Completed build in 09m 22s on Fri, 10 Aug, 11:40 AM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26342

  11. Wouter Wolters commented on patch set 5 08/10/18, 09:42

    RenameFileController.php:162

    second param is not true here

    ReplaceFileController.php:172

    same here
  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/10/18, 09:46

  13. Wouter Wolters commented on patch set 5 CR -1 08/10/18, 10:00

    on it
  14. Wouter Wolters uploaded patch set 6 08/10/18, 10:03

  15. Wouter Wolters voted on patch set 6 V +1 CR +1 08/10/18, 10:03

  16. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/10/18, 10:06

  17. Mathias Brodala commented on patch set 6 08/10/18, 10:08

    GeneralUtility.php:1190

    Shouldn't this also check for `null` too?
  18. Mathias Brodala commented on patch set 6 08/10/18, 10:09

    GeneralUtility.php:1190 Reply

    Otherwise passing `false` will prevent the error being triggered.
  19. TYPO3com voted on patch set 6 V +1 08/10/18, 10:11 Completed build in 08m 28s on Fri, 10 Aug, 12:11 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26346

  20. Wouter Wolters commented on patch set 6 08/10/18, 10:17

    GeneralUtility.php:1190 Reply

    False is catched in the else part IMO
  21. Mathias Brodala commented on patch set 6 08/10/18, 10:28

    GeneralUtility.php:1190 Reply

    Indeed, sorry for the noise. ;-)
  22. Wouter Wolters voted on patch set 6 V +2 CR +2 08/10/18, 10:30

  23. Wouter Wolters merged patch set 7 08/10/18, 10:30