Review main Merged

57771[TASK] Add documentation render directories to .gitignore

Sybille Peters CR +2 V +2 Easy +3 −1 updated 08/10/18, 11:46

Commit message

Add directory created by documentation rendering to .gitignore.

Rendering the docs locally is helpful for checking if it will render
correctly on the server. This will create the rendered files in
typo3/sysext/*/Documentation-GENERATED-temp/.

Adding this to .gitignore will prevent accidentally adding the generated
documentation to a patch.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Björn Jacob +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Björn Jacob +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Sybille Peters uploaded patch set 1 08/02/18, 08:39

  2. TYPO3com voted on patch set 1 V +1 08/02/18, 08:45 Completed build in 06m 26s on Thu, 2 Aug, 10:45 AM Test Summary: 33647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26010

  3. Jörg Bösche voted on patch set 1 CR +1 08/02/18, 11:51

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/05/18, 12:02

  5. Sybille Peters uploaded patch set 2 08/05/18, 12:21

  6. Sybille Peters commented on patch set 2 08/05/18, 12:23

    I changed the rule to be generic, that way all generated docs (system doc and changelog) will be included in the .gitignore rule.
  7. TYPO3com voted on patch set 2 V +1 08/05/18, 12:29 Completed build in 07m 28s on Sun, 5 Aug, 02:29 PM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26197

  8. Jörg Bösche voted on patch set 2 CR +1 08/06/18, 06:14

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/10/18, 10:58

  10. Björn Jacob voted on patch set 2 V +1 CR +1 08/10/18, 11:01

  11. Wouter Wolters voted on patch set 2 V +2 CR +2 08/10/18, 11:46

  12. Wouter Wolters merged patch set 3 08/10/18, 11:46