57782[TASK] Improve layout of service reports
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- Joerg Kummer +1
- Guido Schmechel +1
- Paweł Rogowicz +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Daniel Goerz +1
- Joerg Kummer +1
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2228
Show 23 earlier messages
-
Georg Ringer uploaded patch set 1 08/02/18, 15:55
-
TYPO3com voted on patch set 1 V +1 08/02/18, 16:02 Completed build in 06m 40s on Thu, 2 Aug, 06:02 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26037
-
Wouter Wolters commented on patch set 1 08/02/18, 17:13
-
Wouter Wolters uploaded patch set 2 08/02/18, 17:35
-
Wouter Wolters voted on patch set 2 V +1 CR +1 08/02/18, 17:35
-
TYPO3com voted on patch set 2 V +1 08/02/18, 17:42 Completed build in 07m 23s on Thu, 2 Aug, 07:42 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26042
-
Georg Ringer rebased onto patch set 3 08/02/18, 20:31
-
Georg Ringer commented on patch set 3 08/02/18, 20:32
ServicesListReport.html:18just a test, showing gerrit -
TYPO3com voted on patch set 3 V +1 08/02/18, 20:40 Completed build in 08m 56s on Thu, 2 Aug, 10:40 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26053
-
Wouter Wolters voted on patch set 3 V +1 CR +1 08/02/18, 21:07
-
Daniel Goerz uploaded patch set 4 08/03/18, 09:12
-
Daniel Goerz commented on patch set 4 V +1 CR +1 08/03/18, 09:13
I added a label for the description colum and removed the fixed width for the first column. Looks way better now IMHO. -
TYPO3com voted on patch set 4 V +1 08/03/18, 09:21 Completed build in 08m 56s on Fri, 3 Aug, 11:21 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26062
-
Wouter Wolters commented on patch set 4 CR -1 08/03/18, 11:42
ServicesListReport.html:44tab here -
Daniel Goerz commented on patch set 5 08/03/18, 12:11
Published edit on patch set 4. -
Daniel Goerz commented on patch set 4 08/03/18, 12:12
ServicesListReport.html:44ReplyDone -
Daniel Goerz voted on patch set 5 V +1 CR +1 08/03/18, 12:12
-
TYPO3com voted on patch set 5 V -1 08/03/18, 12:23 Completed build in 11m 38s on Fri, 3 Aug, 02:23 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26078
-
TYPO3com voted on patch set 5 V +1 08/03/18, 12:38 Completed build in 37m 56s on Fri, 3 Aug, 02:38 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26078
-
Guido Schmechel voted on patch set 5 V +1 CR +1 08/04/18, 05:15
-
Paweł Rogowicz voted on patch set 5 CR +1 08/04/18, 12:31
-
Tymoteusz Motylewski commented on patch set 5 08/04/18, 14:30
ServicesListReport.html:26if we don't need the full path to a file here, than we probably don't need it in other places too? -
Joerg Kummer voted on patch set 5 V +1 CR +1 08/04/18, 20:20
-
Anja Leichsenring commented on patch set 5 08/04/18, 20:28
ServicesListReport.html:26ReplyI would prefer to keep it consistent throughout the class - use the full path, or don't. But don't mix. -
Tymoteusz Motylewski commented on patch set 5 CR -1 08/05/18, 07:53
on it -
Daniel Goerz commented on patch set 5 08/05/18, 08:00
ServicesListReport.html:26ReplyThis variable contains the full path to a file. If I am not mistaken labels from at least three different files are used in this template. -
Tymoteusz Motylewski commented on patch set 5 V +2 CR +2 08/05/18, 08:02
all good, we can't shorten the lll path. -
Tymoteusz Motylewski merged patch set 6 08/05/18, 08:02
ServicesListReport.html:44