Review main Merged

57782[TASK] Improve layout of service reports

Georg Ringer CR +2 V +2 Easy +16 −13 updated 08/05/18, 08:02

Commit message

Improve the following issues in the reports module regarding services:

- Use th instead of td
- Use correct labels
- Improved layout
- Add label for description

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Daniel Goerz +1
    • Joerg Kummer +1
    • Guido Schmechel +1
    • Paweł Rogowicz +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Daniel Goerz +1
    • Joerg Kummer +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2228

Show 23 earlier messages
  1. Georg Ringer uploaded patch set 1 08/02/18, 15:55

  2. TYPO3com voted on patch set 1 V +1 08/02/18, 16:02 Completed build in 06m 40s on Thu, 2 Aug, 06:02 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26037

  3. Wouter Wolters commented on patch set 1 08/02/18, 17:13

    ServicesListReport.html:44

    indentation is different on several lines
  1. Wouter Wolters uploaded patch set 2 08/02/18, 17:35

  2. Wouter Wolters voted on patch set 2 V +1 CR +1 08/02/18, 17:35

  3. TYPO3com voted on patch set 2 V +1 08/02/18, 17:42 Completed build in 07m 23s on Thu, 2 Aug, 07:42 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26042

  4. Georg Ringer rebased onto patch set 3 08/02/18, 20:31

  5. Georg Ringer commented on patch set 3 08/02/18, 20:32

    ServicesListReport.html:18

    just a test, showing gerrit
  6. TYPO3com voted on patch set 3 V +1 08/02/18, 20:40 Completed build in 08m 56s on Thu, 2 Aug, 10:40 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26053

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 08/02/18, 21:07

  8. Daniel Goerz uploaded patch set 4 08/03/18, 09:12

  9. Daniel Goerz commented on patch set 4 V +1 CR +1 08/03/18, 09:13

    I added a label for the description colum and removed the fixed width for the first column. Looks way better now IMHO.
  10. TYPO3com voted on patch set 4 V +1 08/03/18, 09:21 Completed build in 08m 56s on Fri, 3 Aug, 11:21 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26062

  11. Wouter Wolters commented on patch set 4 CR -1 08/03/18, 11:42

    ServicesListReport.html:44

    tab here
  12. Daniel Goerz commented on patch set 5 08/03/18, 12:11

    Published edit on patch set 4.
  13. Daniel Goerz commented on patch set 4 08/03/18, 12:12

    ServicesListReport.html:44 Reply

    Done
  14. Daniel Goerz voted on patch set 5 V +1 CR +1 08/03/18, 12:12

  15. TYPO3com voted on patch set 5 V -1 08/03/18, 12:23 Completed build in 11m 38s on Fri, 3 Aug, 02:23 PM Test Summary: 33496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26078

  16. TYPO3com voted on patch set 5 V +1 08/03/18, 12:38 Completed build in 37m 56s on Fri, 3 Aug, 02:38 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26078

  17. Guido Schmechel voted on patch set 5 V +1 CR +1 08/04/18, 05:15

  18. Paweł Rogowicz voted on patch set 5 CR +1 08/04/18, 12:31

  19. Tymoteusz Motylewski commented on patch set 5 08/04/18, 14:30

    ServicesListReport.html:26

    if we don't need the full path to a file here, than we probably don't need it in other places too?
  20. Joerg Kummer voted on patch set 5 V +1 CR +1 08/04/18, 20:20

  21. Anja Leichsenring commented on patch set 5 08/04/18, 20:28

    ServicesListReport.html:26 Reply

    I would prefer to keep it consistent throughout the class - use the full path, or don't. But don't mix.
  22. Tymoteusz Motylewski commented on patch set 5 CR -1 08/05/18, 07:53

    on it
  23. Daniel Goerz commented on patch set 5 08/05/18, 08:00

    ServicesListReport.html:26 Reply

    This variable contains the full path to a file. If I am not mistaken labels from at least three different files are used in this template.
  24. Tymoteusz Motylewski commented on patch set 5 V +2 CR +2 08/05/18, 08:02

    all good, we can't shorten the lll path.
  25. Tymoteusz Motylewski merged patch set 6 08/05/18, 08:02