Review main Merged

57783[TASK] Deprecate property and method in DocumentTemplate

Wouter Wolters CR +2 V +2 Normal +65 −5 updated 08/04/18, 19:34

Commit message

Method addStyleSheet and property $hasDocheader are marked as
deprecated.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Joerg Kummer +1
  • Verified V +2
    • Anja Leichsenring +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Wouter Wolters uploaded patch set 1 08/02/18, 18:21

  2. TYPO3com voted on patch set 1 V -1 08/02/18, 18:32 Completed build in 11m 06s on Thu, 2 Aug, 08:32 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26043

  3. Wouter Wolters rebased onto patch set 2 08/02/18, 21:18

  4. TYPO3com voted on patch set 2 V +1 08/02/18, 21:25 Completed build in 06m 41s on Thu, 2 Aug, 11:25 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26055

  5. Joerg Kummer commented on patch set 2 V +1 CR +1 08/04/18, 17:53

    Also verified ExtensionScan
  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/04/18, 19:34

  7. Anja Leichsenring merged patch set 3 08/04/18, 19:34