Review main Merged

57791[BUGFIX] Select first element in tree when deleting selected node

Paweł Rogowicz CR +2 V +2 Easy +31 −3 updated 08/09/18, 13:06

Commit message

This patch fixes a bug which occured when deleting a currently selected
node. After deleting this node the first element of the tree is
displayed.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Joerg Kummer +1
    • Łukasz Uznański +1
    • Andreas Kienast +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Joerg Kummer +1
    • Łukasz Uznański +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 3348

Show 1423 earlier messages
  1. Paweł Rogowicz uploaded patch set 1 08/03/18, 14:06

  2. TYPO3com voted on patch set 1 V -1 08/03/18, 14:14 Completed build in 08m 01s on Fri, 3 Aug, 04:14 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26087

  3. Łukasz Uznański uploaded patch set 2 08/03/18, 15:15

  4. TYPO3com voted on patch set 2 V +1 08/03/18, 15:23 Completed build in 07m 39s on Fri, 3 Aug, 05:23 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26092

  5. Riccardo De Contardi commented on patch set 2 08/03/18, 19:58

    I added a screenshot to my issue comment to show the action that makes the issue come out.
  6. Łukasz Uznański uploaded patch set 3 08/04/18, 14:35

  7. TYPO3com voted on patch set 3 V -1 08/04/18, 14:35 Completed build in 08s on Sat, 4 Aug, 04:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26138

  8. Łukasz Uznański uploaded patch set 4 08/04/18, 14:36

  9. TYPO3com voted on patch set 4 V +1 08/04/18, 14:42 Completed build in 06m 03s on Sat, 4 Aug, 04:42 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26139

  10. Joerg Kummer commented on patch set 4 08/04/18, 16:35

    Affects also 8.7 branch.
  11. Joerg Kummer updated the commit message in patch set 5 08/04/18, 16:36

  12. TYPO3com voted on patch set 5 V +1 08/04/18, 16:43 Completed build in 07m 16s on Sat, 4 Aug, 06:43 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26146

  13. Joerg Kummer voted on patch set 5 V +1 CR +1 08/04/18, 16:44

  14. Tymoteusz Motylewski commented on patch set 5 CR -1 08/04/18, 16:59

    ContextMenuActions.ts:213

    do we have to access Page Tree internals here? Isn't there an api for selecting a node?

    ContextMenuActions.ts:217

    same here with fsmod
  15. Paweł Rogowicz rebased onto patch set 6 08/04/18, 17:51

  16. Paweł Rogowicz uploaded patch set 7 08/04/18, 17:53

  17. TYPO3com voted on patch set 6 V +1 08/04/18, 18:00 Completed build in 09m 33s on Sat, 4 Aug, 08:00 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26153

  18. TYPO3com voted on patch set 7 V -1 08/04/18, 18:02 Completed build in 09m 02s on Sat, 4 Aug, 08:02 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26154

  19. Łukasz Uznański uploaded patch set 8 08/04/18, 18:10

  20. TYPO3com voted on patch set 8 V +1 08/04/18, 18:18 Completed build in 08m 08s on Sat, 4 Aug, 08:18 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26156

  21. Łukasz Uznański uploaded patch set 9 08/04/18, 18:22

  22. Łukasz Uznański commented on patch set 9 08/04/18, 18:23

    I removed 8.7 from releases, I guess we'll need another patch for 8.7, because in 8.7 there is old pagetree, and there are changes in pagetree js
  23. TYPO3com voted on patch set 9 V +1 08/04/18, 18:28 Completed build in 06m 16s on Sat, 4 Aug, 08:28 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26157

  1. Joerg Kummer voted on patch set 9 V +1 CR +1 08/04/18, 18:31

  2. Anja Leichsenring commented on patch set 9 V -1 08/04/18, 19:45

    Deleting the page via context menu will properly update the state in page tree and working frame. But using the slide action to remove the page from the page tree (pull it out to the left), then the working frame is not refreshed. One can still initiate actions here, however when the first button is clicked, the action continues on page uid 0, which would have been the desired action from the start.
  3. Jigal van Hemert commented on patch set 9 08/04/18, 19:58

    Isn't it more logical from a UX point of view to select the node "above" the deleted one (sibling or parent) after the current node is deleted? If the pagetree is large the user is completely lost if the first node in the tree is selected.
  4. Joerg Kummer commented on patch set 9 08/04/18, 20:10

    @Jigal Good point
  5. Anja Leichsenring commented on patch set 9 08/04/18, 20:45

    > Patch Set 9: > > Isn't it more logical from a UX point of view to select the node "above" the deleted one (sibling or parent) after the current node is deleted? If the pagetree is large the user is completely lost if the first node in the tree is selected. This will easily run into problems, if mountpoints are involved.
  6. Paweł Rogowicz uploaded patch set 10 08/05/18, 09:02

  7. TYPO3com voted on patch set 10 V -1 08/05/18, 09:09 Completed build in 07m 32s on Sun, 5 Aug, 11:09 AM Test Summary: 1 of 33813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26180

  8. TYPO3com commented on patch set 10 08/05/18, 09:24 Completed build in 30m 13s on Sun, 5 Aug, 11:24 AM Test Summary: 1 of 33813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26180

  9. TYPO3com voted on patch set 10 V +1 08/05/18, 09:33 Completed build in 1h 01m 50s on Sun, 5 Aug, 11:33 AM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26180

  10. Łukasz Uznański voted on patch set 10 V +1 CR +1 08/05/18, 09:38

  11. Paweł Rogowicz uploaded patch set 11 08/05/18, 09:47

  12. Paweł Rogowicz uploaded patch set 12 08/05/18, 09:52

  13. TYPO3com voted on patch set 11 V +1 08/05/18, 09:55 Completed build in 07m 59s on Sun, 5 Aug, 11:55 AM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26182

  14. TYPO3com voted on patch set 12 V +1 08/05/18, 10:04 Completed build in 11m 27s on Sun, 5 Aug, 12:04 PM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26184

  15. Anja Leichsenring voted on patch set 12 V +1 CR +1 08/05/18, 10:39

  16. Jigal van Hemert commented on patch set 12 08/05/18, 11:54

    > > Patch Set 9: > > > > Isn't it more logical from a UX point of view to select the node > "above" the deleted one (sibling or parent) after the current node > is deleted? If the pagetree is large the user is completely lost if > the first node in the tree is selected. > > This will easily run into problems, if mountpoints are involved. Can we detect those problems? (and only do something crazy like jump to the first node in those situations) Large pagetrees seem more common than mount points.
  17. Joerg Kummer voted on patch set 12 V +1 CR +1 08/05/18, 13:35

  18. Tymoteusz Motylewski commented on patch set 12 08/05/18, 14:11

    I propose to keep the behaviour as now, the change to detect the node in the more Inteligent way can be easily a separate patch.
  19. Björn Jacob updated the commit message in patch set 13 08/06/18, 19:01

  20. TYPO3com voted on patch set 13 V +1 08/06/18, 19:09 Completed build in 07m 54s on Mon, 6 Aug, 09:09 PM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26230

  21. Łukasz Uznański voted on patch set 13 V +1 CR +1 08/06/18, 20:27

  22. Joerg Kummer voted on patch set 13 V +1 CR +1 08/06/18, 21:04

  23. Andreas Kienast voted on patch set 13 V +1 CR +1 08/07/18, 17:30

  24. Tymoteusz Motylewski commented on patch set 13 V +2 CR +2 08/09/18, 13:06

    have enough votes
  25. Tymoteusz Motylewski merged patch set 14 08/09/18, 13:06