Review main Merged

57795[TASK] Switch skip condition with annotations in RedisBackendTest

Michael Kersten CR +2 V +2 Easy +3 −4 updated 08/04/18, 07:58

Commit message

Use requires annotation for skipping test if php extension redis
is not loaded.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Michael Kersten uploaded patch set 1 08/04/18, 07:21

  2. TYPO3com voted on patch set 1 V -1 08/04/18, 07:28 Completed build in 06m 18s on Sat, 4 Aug, 09:28 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26096

  3. Anja Leichsenring uploaded patch set 2 08/04/18, 07:43

  4. TYPO3com voted on patch set 2 V +1 08/04/18, 07:51 Completed build in 07m 44s on Sat, 4 Aug, 09:51 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26098

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/04/18, 07:51

  6. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/04/18, 07:58

  7. Tymoteusz Motylewski merged patch set 3 08/04/18, 07:58