Review main Merged

57796[TASK] Switch skip condition with annotations in RedisSessionBackendTest

Michael Kersten CR +2 V +2 Easy +2 −3 updated 08/04/18, 08:42

Commit message

Use requires annotation for skipping test if php extension redis
is not loaded.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 59

  1. Michael Kersten uploaded patch set 1 08/04/18, 07:28

  2. TYPO3com voted on patch set 1 V -1 08/04/18, 07:34 Completed build in 06m 05s on Sat, 4 Aug, 09:34 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26097

  3. TYPO3com commented on patch set 1 08/04/18, 07:54 Completed build in 31m 29s on Sat, 4 Aug, 09:54 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26097

  4. TYPO3com commented on patch set 1 08/04/18, 08:04 Completed build in 1h 07m 05s on Sat, 4 Aug, 10:04 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26097

  5. Anja Leichsenring rebased onto patch set 2 08/04/18, 08:04

  6. TYPO3com voted on patch set 2 V +1 08/04/18, 08:10 Completed build in 05m 57s on Sat, 4 Aug, 10:10 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26100

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/04/18, 08:15

  8. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/04/18, 08:42

  9. Tymoteusz Motylewski merged patch set 3 08/04/18, 08:42