Review main Merged

57797[TASK] Reactivate former skipped test in RendererRegistryTest

Anja Leichsenring CR +2 V +2 Easy +0 −2 updated 08/04/18, 12:19

Commit message

The test has been skipped due to a bug in PHP > 7.0, so
for v9 the skip condition doesn't apply anymore.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Łukasz Uznański +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Anja Leichsenring uploaded patch set 1 08/04/18, 08:17

  2. TYPO3com voted on patch set 1 V -1 08/04/18, 08:17 Completed build in 09s on Sat, 4 Aug, 10:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26101

  3. Anja Leichsenring uploaded patch set 2 08/04/18, 08:25

  4. TYPO3com voted on patch set 2 V +1 08/04/18, 08:31 Completed build in 06m 12s on Sat, 4 Aug, 10:31 AM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26103

  5. Łukasz Uznański voted on patch set 2 V +1 CR +1 08/04/18, 11:50

  6. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/04/18, 12:19

  7. Tymoteusz Motylewski merged patch set 3 08/04/18, 12:19