Review main Merged

57799[TASK] Switch skip condition to annotations in PdoBackendTest

Michael Kersten CR +2 V +2 Easy +2 −11 updated 08/04/18, 09:46

Commit message

Use requires annotation for skipping test if php extension pdo_sqlite
is not loaded.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Michael Kersten uploaded patch set 1 08/04/18, 08:31

  2. TYPO3com voted on patch set 1 V +1 08/04/18, 08:39 Completed build in 07m 52s on Sat, 4 Aug, 10:39 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26104

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/18, 08:41

  4. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 08/04/18, 09:46

  5. Tymoteusz Motylewski merged patch set 2 08/04/18, 09:46