Review main Merged

57802[TASK] Switch some skipped conditions to annotations in GeneralUtilityTest

Johannes Seipelt CR +2 V +2 Easy +4 −14 updated 08/04/18, 10:23

Commit message

Set requirements for some tests by annotation instead of conditions.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Anja Leichsenring +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Johannes Seipelt uploaded patch set 1 08/04/18, 08:58

  2. TYPO3com voted on patch set 1 V +1 08/04/18, 09:06 Completed build in 07m 35s on Sat, 4 Aug, 11:06 AM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26110

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/04/18, 09:08

  4. Łukasz Uznański voted on patch set 1 V +1 CR +1 08/04/18, 09:42

  5. Tymoteusz Motylewski commented on patch set 1 CR -1 08/04/18, 09:42

    the commit message title should be written in the imperative mood. see https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/CommitMessage.html
  6. Johannes Seipelt rebased onto patch set 2 08/04/18, 10:01

  7. TYPO3com voted on patch set 2 V +1 08/04/18, 10:08 Completed build in 06m 38s on Sat, 4 Aug, 12:08 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26114

  8. Johannes Seipelt updated the commit message in patch set 3 08/04/18, 10:11

  9. Johannes Seipelt updated the commit message in patch set 4 08/04/18, 10:12

  10. Tymoteusz Motylewski voted on patch set 4 V +1 CR +1 08/04/18, 10:16

  11. TYPO3com voted on patch set 3 V +1 08/04/18, 10:18 Completed build in 07m 08s on Sat, 4 Aug, 12:18 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26117

  12. TYPO3com voted on patch set 4 V +1 08/04/18, 10:21 Completed build in 08m 24s on Sat, 4 Aug, 12:21 PM Test Summary: 33648 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26118

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 08/04/18, 10:23

  14. Anja Leichsenring merged patch set 5 08/04/18, 10:23