Review main Merged

57803[TASK] Reactivate test in ConditionMatcherTest

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 08/04/18, 17:05

Commit message

The test code has been fixed to actually do what the test name says.

Additionally, a comment has been added to the code being tested,
so the intention of the regex condition is clearer.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Łukasz Uznański +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Łukasz Uznański +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Anja Leichsenring uploaded patch set 1 08/04/18, 10:02

  2. TYPO3com voted on patch set 1 V -1 08/04/18, 10:03 Completed build in 14s on Sat, 4 Aug, 12:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26115

  3. Anja Leichsenring uploaded patch set 2 08/04/18, 10:07

  4. Thomas Löffler commented on patch set 1 08/04/18, 10:14

    AbstractConditionMatcher.php:220

    The pattern "/^\*.+\*$/" is imho better understandable and gives you the same result.
  5. TYPO3com voted on patch set 2 V +1 08/04/18, 10:14 Completed build in 07m 16s on Sat, 4 Aug, 12:14 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26116

  6. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/04/18, 12:24

  7. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 08/04/18, 12:24

  8. Łukasz Uznański voted on patch set 2 V +1 CR +1 08/04/18, 14:09

  9. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/04/18, 17:05

  10. Tymoteusz Motylewski merged patch set 3 08/04/18, 17:05