Review main Merged

57805[BUGFIX] Detect current ImageMagick Version 7 for Windows.

Michael Kersten CR +2 V +2 Easy +9 −1 updated 08/05/18, 08:59

Commit message

Try to use magick.exe if executable does not exists.

ImageMagick Version 7 for Windows does not use the executables for
identify, convert and combine/composite anymore. Instead the executable
magick.exe is used.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Guido Schmechel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 915

  1. Michael Kersten uploaded patch set 1 08/04/18, 12:11

  2. TYPO3com voted on patch set 1 V -1 08/04/18, 12:11 Completed build in 14s on Sat, 4 Aug, 02:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26123

  3. Michael Kersten uploaded patch set 2 08/04/18, 12:15

  4. TYPO3com voted on patch set 2 V -1 08/04/18, 12:15 Completed build in 09s on Sat, 4 Aug, 02:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26124

  5. Michael Kersten uploaded patch set 3 08/04/18, 12:22

  6. TYPO3com voted on patch set 3 V +1 08/04/18, 12:30 Completed build in 08m 21s on Sat, 4 Aug, 02:30 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26126

  7. Michael Kersten rebased onto patch set 4 08/04/18, 12:36

  8. TYPO3com commented on patch set 4 08/04/18, 12:43 Completed build in 06m 31s on Sat, 4 Aug, 02:43 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26127

  9. Michael Kersten updated the commit message in patch set 5 08/04/18, 12:52

  10. TYPO3com voted on patch set 5 V -1 08/04/18, 12:59 Completed build in 07m 40s on Sat, 4 Aug, 02:59 PM Test Summary: 1 of 33813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26129

  11. TYPO3com voted on patch set 5 V +1 08/04/18, 13:05 Completed build in 21m 08s on Sat, 4 Aug, 03:05 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26129

  12. Guido Schmechel commented on patch set 5 V +1 CR +1 08/04/18, 13:28

    Image Magick version 6 or higher [Active] An ImageMagick version 6 or higher was found in path C:/Program Files/ImageMagick-7.0.8-Q16/. Checked: - Settings -> Configuration presets -> Set image path - "Test images" in image processing - Crop Images via Text/Images CE - Reports -> Installed Services (Windows 10 / 9.4-dev)
  13. Jigal van Hemert voted on patch set 5 V +2 CR +2 08/05/18, 08:59

  14. Jigal van Hemert merged patch set 6 08/05/18, 08:59

  15. Jigal van Hemert commented on patch set 6 08/05/18, 08:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2c0998ae4275b36b246b823da2fe3467fbb65ec1