Review main Merged

57809[BUGFIX] Move page correctly when droping page before another one

Paweł Rogowicz CR +2 V +2 Easy +14 −14 updated 08/05/18, 08:06

Commit message

Fixes an issue where drag and dropping page before a another one didn't
detect the previous page correctly. DataHandler always expect
us to put a node AFTER. So when we want to place a page before, we need
to find previous page and put the new on after it.

Now it correctly compares depth of the node mouse is over with a previous
node. Before it took a dragged node depth for a comparison, which was wrong.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Joerg Kummer +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Paweł Rogowicz uploaded patch set 1 08/04/18, 17:02

  2. TYPO3com voted on patch set 1 V +1 08/04/18, 17:10 Completed build in 07m 26s on Sat, 4 Aug, 07:10 PM Test Summary: 33651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26147

  3. Tymoteusz Motylewski commented on patch set 1 CR -1 08/04/18, 17:10

    please descrivbe the code change, why does it solves the problem.
  4. Tymoteusz Motylewski updated the commit message in patch set 2 08/04/18, 18:08

  5. TYPO3com voted on patch set 2 V +1 08/04/18, 18:16 Completed build in 08m 01s on Sat, 4 Aug, 08:16 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26155

  6. Joerg Kummer commented on patch set 2 08/04/18, 18:58

    @Paweł: I couldnt find out to move pages without wrong placements. Can we have a look together tomorrow?
  7. Joerg Kummer commented on patch set 2 V +1 CR +1 08/05/18, 07:53

    You need to disable cache to test this behaviour.
  8. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/05/18, 08:06

  9. Tymoteusz Motylewski merged patch set 3 08/05/18, 08:06