Review main Abandoned

57810[TASK] Switch skip condition with annotations in MemcachedBackendTest

Łukasz Uznański CR 0 V 0 Easy +3 −3 updated 08/04/18, 19:13

Commit message

Set requirements for some tests by annotation instead of conditions.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Łukasz Uznański uploaded patch set 1 08/04/18, 17:07

  2. Tymoteusz Motylewski commented on patch set 1 CR -1 08/04/18, 17:12

    please write commit message title in imperative mood
  3. TYPO3com voted on patch set 1 V +1 08/04/18, 17:15 Completed build in 07m 33s on Sat, 4 Aug, 07:15 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26149

  4. Łukasz Uznański updated the commit message in patch set 2 08/04/18, 17:43

  5. Johannes Seipelt commented on patch set 2 CR -1 08/04/18, 17:48

    check my comment

    MemcachedBackendTest.php:31

    looks this test should only require on of both extensions to run. if you look at the old if clause the test is only skipped if both extensions are missing
  6. TYPO3com voted on patch set 2 V +1 08/04/18, 17:50 Completed build in 06m 38s on Sat, 4 Aug, 07:50 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26151

  7. Łukasz Uznański commented on patch set 2 08/04/18, 18:18

    MemcachedBackendTest.php:31 Reply

    yea, that's true, I will dig into 'requires' and check if it's possible to do ||
  8. Łukasz Uznański abandoned the change 08/04/18, 19:13