57810[TASK] Switch skip condition with annotations in MemcachedBackendTest
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 68
-
Łukasz Uznański uploaded patch set 1 08/04/18, 17:07
-
Tymoteusz Motylewski commented on patch set 1 CR -1 08/04/18, 17:12
please write commit message title in imperative mood -
TYPO3com voted on patch set 1 V +1 08/04/18, 17:15 Completed build in 07m 33s on Sat, 4 Aug, 07:15 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26149
-
Łukasz Uznański updated the commit message in patch set 2 08/04/18, 17:43
-
Johannes Seipelt commented on patch set 2 CR -1 08/04/18, 17:48
check my commentMemcachedBackendTest.php:31looks this test should only require on of both extensions to run. if you look at the old if clause the test is only skipped if both extensions are missing -
TYPO3com voted on patch set 2 V +1 08/04/18, 17:50 Completed build in 06m 38s on Sat, 4 Aug, 07:50 PM Test Summary: 33654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26151
-
Łukasz Uznański commented on patch set 2 08/04/18, 18:18
MemcachedBackendTest.php:31Replyyea, that's true, I will dig into 'requires' and check if it's possible to do || -
Łukasz Uznański abandoned the change 08/04/18, 19:13