Review TYPO3_8-7 Merged

57813[BUGFIX] Detect current ImageMagick Version 7 for Windows.

Jigal van Hemert CR +2 V +2 Easy +9 −1 updated 08/20/18, 11:01

Commit message

Try to use magick.exe if executable does not exists.

ImageMagick Version 7 for Windows does not use the executables for
identify, convert and combine/composite anymore. Instead the executable
magick.exe is used.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Jigal van Hemert commented on patch set 1 08/05/18, 08:59

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/05/18, 09:08 Completed build in 08m 19s on Sun, 5 Aug, 11:08 AM Test Summary: 59296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2825

  3. Jigal van Hemert commented on patch set 1 V +2 CR +2 08/05/18, 10:26

    Straight backport, no code changes in this area between branches.
  4. Jigal van Hemert merged patch set 2 08/05/18, 10:26

  5. Benni Mack commented on patch set 2 08/20/18, 10:45

    post -1, this change has the Environment API included. which is not available in TYPO3 v8. @Jigal, please revert.
  6. Jigal van Hemert wrote 08/20/18, 11:01

    Created a revert of this change as I2eba784e0a6fd83d1d9a70db7b57c89c54d29f55