Review TYPO3_8-7 Merged

57814[BUGFIX] Remove attribute 'selected' if its value is false

Anja Leichsenring CR +2 V +2 Normal +140 −9 updated 08/14/18, 17:18

Commit message

If the selected attribute is set to false (or zero), the
attribute itself must not be shown as even if it is empty it would be
meant to set the option to selected.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Anja Leichsenring uploaded patch set 1 08/05/18, 09:51

  2. TYPO3com voted on patch set 1 V -1 08/05/18, 10:01 Completed build in 10m 23s on Sun, 5 Aug, 12:01 PM Test Summary: 42 of 59743 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2826

  3. Łukasz Uznański voted on patch set 1 CR +1 08/05/18, 10:01

  4. Łukasz Uznański voted on patch set 1 CR 0 08/05/18, 10:03

  5. Anja Leichsenring uploaded patch set 2 08/05/18, 10:31

  6. TYPO3com voted on patch set 2 V -1 08/05/18, 10:31 Completed build in 13s on Sun, 5 Aug, 12:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2828

  7. Anja Leichsenring uploaded patch set 3 08/05/18, 10:37

  8. TYPO3com voted on patch set 3 V +1 08/05/18, 10:43 Completed build in 06m 25s on Sun, 5 Aug, 12:43 PM Test Summary: 59338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2829

  9. Mona Muzaffar voted on patch set 3 V +1 08/10/18, 09:12

  10. Christian Kuhn voted on patch set 3 CR +1 08/14/18, 17:16

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/14/18, 17:17

  12. Anja Leichsenring merged patch set 4 08/14/18, 17:18