57821[TASK] Deprecate GeneralUtility::unQuoteFilenames
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Georg Ringer +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Utility/CommandUtility.php+31 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85760-DeprecateGeneralUtilityunQuoteFilenames.rstnew+32 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −179
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php+179 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 810
-
Wouter Wolters uploaded patch set 1 08/05/18, 13:05
-
TYPO3com voted on patch set 1 V +1 08/05/18, 13:12 Completed build in 06m 33s on Sun, 5 Aug, 03:12 PM Test Summary: 33655 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26201
-
Łukasz Uznański voted on patch set 1 V +1 CR +1 08/05/18, 19:07
-
Wouter Wolters uploaded patch set 2 08/08/18, 11:30
-
TYPO3com voted on patch set 2 V +1 08/08/18, 11:38 Completed build in 07m 18s on Wed, 8 Aug, 01:38 PM Test Summary: 33676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26263
-
Benni Mack commented on patch set 2 08/08/18, 20:10
Can we move the unit tests to CommandUtility in some way? -
Wouter Wolters commented on patch set 2 08/08/18, 20:15
Could be done, I dropped the second parameter of the function because that is not in use. I need to strip half of the unit test because of that -
Georg Ringer voted on patch set 2 V +1 CR +1 08/08/18, 20:33
-
Christian Kuhn voted on patch set 2 V +2 CR +2 08/09/18, 11:54
-
Christian Kuhn merged patch set 3 08/09/18, 11:54