Review main Merged

57829[TASK] Improve readability of 8.x Changelog

Daniel Siepmann CR +2 V +2 Hard +441 −428 updated 08/09/18, 11:39

Commit message

Only breaking changes and important changes were adjusted for now.

* Fix rst syntax issues, like missing blank line before list.
* Add roles for highlighting of inline files and code.
* Add link to mentioned issues.
* Prefix PHP Globals with $GLOBALS[] to keep things as they are in real
  world and to keep it the same between all files.
* Use single formats, e.g. always '*' for lists. This will make
  refactorings and other stuff easier.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 80

Show 60 more files

Review log 1624

  1. Daniel Siepmann uploaded patch set 1 08/07/18, 11:00

  2. Björn Jacob voted on patch set 1 V +1 CR +1 08/07/18, 11:04

  3. TYPO3com voted on patch set 1 V +1 08/07/18, 11:07 Completed build in 06m 41s on Tue, 7 Aug, 01:07 PM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26246

  4. Daniel Siepmann uploaded patch set 2 08/07/18, 13:22

  5. Daniel Siepmann updated the commit message in patch set 3 08/07/18, 13:22

  6. TYPO3com voted on patch set 2 V +1 08/07/18, 13:29 Completed build in 07m 08s on Tue, 7 Aug, 03:29 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26253

  7. TYPO3com voted on patch set 3 V +1 08/07/18, 13:31 Completed build in 08m 17s on Tue, 7 Aug, 03:31 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26254

  8. Daniel Siepmann uploaded patch set 4 08/07/18, 15:15

  9. TYPO3com voted on patch set 4 V +1 08/07/18, 15:22 Completed build in 06m 56s on Tue, 7 Aug, 05:22 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26255

  10. Daniel Siepmann uploaded patch set 5 08/07/18, 16:04

  11. TYPO3com voted on patch set 5 V +1 08/07/18, 16:11 Completed build in 06m 06s on Tue, 7 Aug, 06:11 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26256

  12. Daniel Siepmann uploaded patch set 6 08/09/18, 06:27

  13. Daniel Siepmann uploaded patch set 7 08/09/18, 06:32

  14. TYPO3com voted on patch set 6 V +1 08/09/18, 06:33 Completed build in 06m 04s on Thu, 9 Aug, 08:33 AM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26277

  15. TYPO3com voted on patch set 7 V +1 08/09/18, 06:40 Completed build in 08m 14s on Thu, 9 Aug, 08:40 AM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26279

  16. Markus Klein commented on patch set 7 08/09/18, 08:07

    Breaking-76802-DropXcacheCacheBackend.rst:25

    shouldn't that be lowercase?
  17. Markus Klein commented on patch set 7 08/09/18, 09:13

    Feature-79622-NewDefaultLayoutForFluidStyledContent.rst:3

    why is that needed? where do we reference to here?

    Important-82763-GlobalFluidExpressionNodeTypeAndTemplatePreProcessorConfiguration.rst:32

    space too much
  18. Daniel Siepmann uploaded patch set 8 08/09/18, 09:34

  19. Daniel Siepmann commented on patch set 7 08/09/18, 09:34

    Feature-79622-NewDefaultLayoutForFluidStyledContent.rst:3 Reply

    From within Changelog/8.6/Breaking-79622-DefaultLayoutsForFluidStyledContentChanged.rst There was just a plain text before, this way we can link to this section.
  20. TYPO3com voted on patch set 8 V +1 08/09/18, 09:40 Completed build in 06m 28s on Thu, 9 Aug, 11:40 AM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26280

  21. Markus Klein voted on patch set 8 V +1 CR +1 08/09/18, 09:43

  22. Christian Kuhn voted on patch set 8 V +2 CR +2 08/09/18, 11:38

  23. Christian Kuhn merged patch set 9 08/09/18, 11:38

  24. Christian Kuhn commented on patch set 9 08/09/18, 11:39

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ae197e879163fe2f22f715d42528b8460d0c1051