Review main Merged

57833[BUGFIX] Use correct server variable for domain lock evaluation

Markus Klein CR +2 V +2 Easy +7 −7 updated 08/09/18, 10:18

Commit message

Patch https://review.typo3.org/57759 introduced a regression by using
REMOTE_HOST instead of HTTP_HOST for matching an authenticating user
against a configured domain lock.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 69

  1. Markus Klein uploaded patch set 1 08/07/18, 21:39

  2. TYPO3com voted on patch set 1 V -1 08/07/18, 21:40 Completed build in 09s on Tue, 7 Aug, 11:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26262

  3. Christian Kuhn rebased onto patch set 2 08/09/18, 10:01

  4. TYPO3com commented on patch set 2 08/09/18, 10:08 Completed build in 07m 07s on Thu, 9 Aug, 12:08 PM Test Summary: 9 of 33855 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26281

  5. Christian Kuhn uploaded patch set 3 08/09/18, 10:09

  6. TYPO3com voted on patch set 3 V +1 08/09/18, 10:16 Completed build in 06m 23s on Thu, 9 Aug, 12:16 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26282

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/09/18, 10:16

  8. Andreas Kienast voted on patch set 3 V +2 CR +2 08/09/18, 10:18

  9. Andreas Kienast merged patch set 4 08/09/18, 10:18