57835[TASK] Use extractors to get meta data
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+19 −76
- typo3/sysext/core/Classes/Resource/Index/LocalExtractor.phpnew+109 −0
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php2+21 −13
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php4new+103 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-85786-ExtractorServiceToComposeFileMetadataAdded.rstnew+18 −0
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+19 −73
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.phpnew+178 −0
- typo3/sysext/core/ext_localconf.php+1 −0
Review log 1014
-
Andreas Kienast uploaded patch set 1 08/08/18, 14:54
-
TYPO3com voted on patch set 1 V -1 08/08/18, 15:02 Completed build in 07m 20s on Wed, 8 Aug, 05:02 PM Test Summary: 9 of 33855 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26265
-
Markus Klein commented on patch set 1 08/08/18, 15:04
ExtractorService.php:54an empty value by default?ExtractorService.php:99maybe make it protected so it is mockable? -
Andreas Kienast commented on patch set 1 08/08/18, 16:03
MetaDataRepository.php:240ReplyWell, the repository class is callable from anywhere. The ExtractorService only stores the resolved extractors per driver, that should be fine. If not, it's of course changeable.ExtractorService.php:54ReplyBecause of the array_merge() call below, to ensure there is at least _one_ item. I do it that way, because executing array_merge in a loop is expensive, see https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loopExtractorService.php:99ReplyAck -
Andreas Kienast uploaded patch set 2 08/08/18, 18:18
-
TYPO3com voted on patch set 2 V +1 08/08/18, 18:25 Completed build in 07m 19s on Wed, 8 Aug, 08:25 PM Test Summary: 33702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26266
-
Andreas Kienast uploaded patch set 3 08/08/18, 18:34
-
TYPO3com voted on patch set 3 V +1 08/08/18, 18:40 Completed build in 06m 07s on Wed, 8 Aug, 08:40 PM Test Summary: 33702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26267
-
Andreas Kienast commented on patch set 3 CR -1 08/08/18, 18:46
I need to take another look, there's a potential recursion now. -
Andreas Kienast uploaded patch set 4 08/08/18, 19:47
-
TYPO3com voted on patch set 4 V +1 08/08/18, 19:54 Completed build in 06m 49s on Wed, 8 Aug, 09:54 PM Test Summary: 33702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26268
-
Andreas Kienast commented on patch set 4 V -1 08/09/18, 13:02
Metadata don't get loaded anymore for newly uploaded files -
Andreas Kienast commented on patch set 4 08/09/18, 13:48
Meh, stale cache hit me once more. But the current state outrules the possible exclusion of meta data. -
Andreas Kienast abandoned the change 08/09/18, 14:14
Does not solve the real issue
MetaDataRepository.php:240