57836[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Paweł Rogowicz +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Paweł Rogowicz +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Andreas Kienast uploaded patch set 1 08/08/18, 20:39
-
TYPO3com voted on patch set 1 V +1 08/08/18, 20:46 Completed build in 06m 46s on Wed, 8 Aug, 10:46 PM Test Summary: 33696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26270
-
Tymoteusz Motylewski commented on patch set 1 08/09/18, 14:16
will take a look -
Mona Muzaffar voted on patch set 1 V +1 08/10/18, 10:06
-
Mona Muzaffar voted on patch set 1 CR +1 08/10/18, 11:47
-
Tymoteusz Motylewski commented on patch set 1 CR -1 08/10/18, 13:19
category tree uses the event in both cases for updating its view. So I would keep it. Maybe we should change the name to nodeSelectionChangedAfter ? I see 2 solutions 1) introduce new event only on selection 2) pass the node state to the listener (maybe it's done already?) so it can check if this was a selection or unselection itself. -
Benni Mack commented on patch set 1 08/24/18, 16:41
Tymek, can you elaborate on how to continue? it's very annoying bug in master. -
Paweł Rogowicz commented on patch set 1 V +1 CR +1 08/26/18, 09:23
I checked it and I think it's works fine. I debug it and category tree doesn't use this function, category tree use function from SvgTree.js -
Andreas Kienast uploaded patch set 2 09/03/18, 20:20
-
Andreas Kienast updated the commit message in patch set 3 09/03/18, 20:22
-
Tymoteusz Motylewski voted on patch set 3 CR +1 09/03/18, 20:23
-
TYPO3com voted on patch set 2 V +1 09/03/18, 20:41 Completed build in 17m 13s on Mon, 3 Sep, 10:41 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27718
-
TYPO3com voted on patch set 3 V +1 09/03/18, 20:43 Completed build in 19m 08s on Mon, 3 Sep, 10:43 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27719
-
Paweł Rogowicz voted on patch set 3 V +1 CR +1 09/04/18, 07:35
-
Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 09/04/18, 07:36
-
Tymoteusz Motylewski merged patch set 4 09/04/18, 07:37