Review main Merged

57842[BUGFIX] Extract metadata for new files in storage

Andreas Kienast CR +2 V +2 Easy +5 −0 updated 08/19/18, 20:41

Commit message

If files in a remote storage are fetched the first time by FAL, the
metadata of these files is now extracted automatically, if the storage
supports this feature.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Frank Nägler +1
    • Frans Saris +1
    • Mathias Brodala +1
  • Verified V +2
    • Jigal van Hemert +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Andreas Kienast uploaded patch set 1 08/09/18, 14:18

  2. Mathias Brodala updated the commit message in patch set 2 08/09/18, 14:24

  3. Mathias Brodala voted on patch set 2 CR +1 08/09/18, 14:24

  4. TYPO3com voted on patch set 1 V +1 08/09/18, 14:25 Completed build in 06m 53s on Thu, 9 Aug, 04:25 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26295

  5. TYPO3com voted on patch set 2 V +1 08/09/18, 14:29 Completed build in 05m 41s on Thu, 9 Aug, 04:29 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26296

  6. Frans Saris commented on patch set 2 08/09/18, 14:31

    ResourceFactory.php:438

    Can't we move this to `$indexer->createIndexEntry()`?
  7. Andreas Kienast uploaded patch set 3 08/09/18, 15:44

  8. Andreas Kienast updated the commit message in patch set 4 08/09/18, 15:44

  9. TYPO3com voted on patch set 3 V +1 08/09/18, 15:55 Completed build in 11m 48s on Thu, 9 Aug, 05:55 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26308

  10. TYPO3com voted on patch set 4 V +1 08/09/18, 15:57 Completed build in 12m 09s on Thu, 9 Aug, 05:57 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26309

  11. Frans Saris voted on patch set 4 CR +1 08/09/18, 20:52

  12. Mathias Brodala voted on patch set 4 CR +1 08/10/18, 07:29

  13. Tymoteusz Motylewski commented on patch set 4 08/10/18, 08:25

    How this can be tested?
  14. Andreas Kienast commented on patch set 4 08/10/18, 08:43

    > Patch Set 4: > > How this can be tested? If you have a custom driver that uses a remote storage with files in it, FAL will fetch the metadata from them if you have a custom extractor. Otherwise, put a .youtube file into fileadmin (manually, not with TYPO3) and add a breakpoint in the online media extractor. Now open the filelist, the extractor should be called for that file.
  15. Frank Nägler voted on patch set 4 V +1 CR +1 08/18/18, 11:50

  16. Jigal van Hemert voted on patch set 4 V +2 CR +2 08/19/18, 20:40

  17. Jigal van Hemert merged patch set 5 08/19/18, 20:40

  18. Jigal van Hemert commented on patch set 5 08/19/18, 20:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 77607b6a4aa33660456c25b25fe385399edf52d7