57843[TASK] Deprecate several constants from SystemEnvironmentBuilder
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
- Mathias Brodala +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+1 −1
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+1 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+10 −6
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+5 −5
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85793-DeprecateSeveralConstantsFromSystemEnvironmentBuilder.rst3new+64 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+6 −6
- typo3/sysext/core/Tests/UnitDeprecated/Encoder/JavaScriptEncoderTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/EmailAddressValidatorTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+6 −6
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+26 −26
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstantMatcher.php+60 −0
Review log 1317
-
Wouter Wolters uploaded patch set 1 08/09/18, 14:43
-
TYPO3com voted on patch set 1 V +1 08/09/18, 14:50 Completed build in 07m 32s on Thu, 9 Aug, 04:50 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26297
-
Mathias Brodala commented on patch set 1 08/09/18, 15:03
I don't expect everyone to have the ASCII table in his head so I'd generally recommend readable escape sequences instead.Deprecation-85793-DeprecateSeveralConstantsFromSystemEnvironmentBuilder.rst:15I'd prefer "\0".Deprecation-85793-DeprecateSeveralConstantsFromSystemEnvironmentBuilder.rst:18I'd prefer "\t"Deprecation-85793-DeprecateSeveralConstantsFromSystemEnvironmentBuilder.rst:21No idea about this one. -
Xavier Perseguers updated the commit message in patch set 2 08/09/18, 15:04
-
Xavier Perseguers commented on patch set 2 08/09/18, 15:06
Just to understand it right, what's the rationale for deprecating say TAB but keep LF, CR, ...? -
Wouter Wolters commented on patch set 2 08/09/18, 15:08
If you check the code you will see manymore calls to chr() function, I just copied it over from what we define in the constant itself. @xavier These 3 were on my list to deprecate. We need @benni here for an answer on that. -
TYPO3com voted on patch set 2 V +1 08/09/18, 15:14 Completed build in 09m 27s on Thu, 9 Aug, 05:14 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26303
-
Mathias Brodala commented on patch set 2 08/10/18, 07:32
> If you check the code you will see manymore calls to chr() > function, I just copied it over from what we define in the constant > itself. Yeah and I think that these should be replaced by readable escape sequences too but in a different change. -
Wouter Wolters uploaded patch set 3 08/10/18, 09:33
-
Wouter Wolters uploaded patch set 4 08/10/18, 09:35
-
TYPO3com voted on patch set 3 V -1 08/10/18, 09:43 Completed build in 09m 07s on Fri, 10 Aug, 11:43 AM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26343
-
TYPO3com voted on patch set 4 V +1 08/10/18, 09:44 Completed build in 08m 21s on Fri, 10 Aug, 11:44 AM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26344
-
Mathias Brodala commented on patch set 4 CR +1 08/10/18, 09:46
A few strings could be merged by now but it's fine. ;-) -
Christian Kuhn commented on patch set 4 08/14/18, 11:40
xavier, one of the bad things about the CR, LF and friends is that they are not 'namespaced' in any way. for instance magento uses the some ones. that's why the 'only define if not yet defined'. in order to run better with other frameworks, such things should just be avoided entirely. -
Christian Kuhn voted on patch set 4 V +1 CR +1 08/14/18, 11:45
-
Benni Mack voted on patch set 4 V +2 CR +2 08/14/18, 12:18
-
Benni Mack merged patch set 5 08/14/18, 12:19