Review main Abandoned

57844[BUGFIX] Reintroduce GroupedForViewHelper

Xavier Perseguers CR 0 V 0 Normal +154 −0 updated 08/09/18, 15:34

Commit message

This ViewHelper has been silently forgotten when TYPO3
switched to Fluid standalone.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Xavier Perseguers uploaded patch set 1 08/09/18, 14:58

  2. Mathias Brodala commented on patch set 1 08/09/18, 15:05

    GroupedForViewHelper.php:85

    This should be refreshed to use renderStatic() instead just like all other viewhelpers.
  3. Wouter Wolters commented on patch set 1 CR -1 08/09/18, 15:05

  4. TYPO3com voted on patch set 1 V +1 08/09/18, 15:08 Completed build in 09m 05s on Thu, 9 Aug, 05:08 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26300

  5. Xavier Perseguers uploaded patch set 2 08/09/18, 15:16

  6. TYPO3com voted on patch set 2 V -1 08/09/18, 15:16 Completed build in 09s on Thu, 9 Aug, 05:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26306

  7. Xavier Perseguers abandoned the change 08/09/18, 15:34

    It was actually moved to Fluid standalone and as such its namespace changed. I extended it, meaning it broke.