Review main Merged

57847[TASK] Refactor SaltFactory

Christian Kuhn CR +2 V +2 Hard +520 −207 updated 08/09/18, 18:39

Commit message

The patch deprecates static SaltFactory::getSaltingInstance()
and replaces it with the two new non-static methods.
The ->get() method returns a hash instance to check a given password
against a given hash, and ->getDefaultHashInstance() which returns
an instance of the configured default hash method to calculate
a hash for a new password.

The new methods are now strict, non-static and throw exceptions if
something goes wrong. This simplifies mocking in tests and sanitizes
password hash handling in the core.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 1929

Show 24 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/09/18, 15:48

  2. Christian Kuhn uploaded patch set 2 08/09/18, 15:48

  3. TYPO3com voted on patch set 1 V -1 08/09/18, 15:48 Completed build in 28s on Thu, 9 Aug, 05:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26311

  4. TYPO3com voted on patch set 2 V +1 08/09/18, 16:01 Completed build in 12m 46s on Thu, 9 Aug, 06:01 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26312

  1. Christian Kuhn uploaded patch set 3 08/09/18, 16:40

  2. Christian Kuhn updated the commit message in patch set 4 08/09/18, 16:42

  3. TYPO3com voted on patch set 3 V +1 08/09/18, 16:48 Completed build in 07m 42s on Thu, 9 Aug, 06:48 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26316

  4. Christian Kuhn updated the commit message in patch set 5 08/09/18, 16:50

  5. Christian Kuhn commented on patch set 6 08/09/18, 16:50

    Published edit on patch set 5.
  6. TYPO3com voted on patch set 4 V +1 08/09/18, 16:51 Completed build in 08m 57s on Thu, 9 Aug, 06:51 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26317

  7. TYPO3com voted on patch set 5 V +1 08/09/18, 16:58 Completed build in 08m 19s on Thu, 9 Aug, 06:58 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26319

  8. TYPO3com voted on patch set 6 V +1 08/09/18, 16:59 Completed build in 08m 12s on Thu, 9 Aug, 06:59 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26320

  9. Markus Klein updated the commit message in patch set 7 08/09/18, 17:03

  10. Andreas Kienast commented on patch set 7 CR -1 08/09/18, 17:10

    on it
  11. TYPO3com voted on patch set 7 V +1 08/09/18, 17:11 Completed build in 07m 15s on Thu, 9 Aug, 07:11 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26321

  12. Andreas Kienast uploaded patch set 8 08/09/18, 17:14

  13. Andreas Kienast uploaded patch set 9 08/09/18, 17:15

  14. Wouter Wolters voted on patch set 9 CR +1 08/09/18, 17:19

  15. Andreas Kienast commented on patch set 9 V +1 CR +1 08/09/18, 17:21

    Tested backend login, password change with login, frontend login.
  16. TYPO3com voted on patch set 8 V +1 08/09/18, 17:22 Completed build in 07m 44s on Thu, 9 Aug, 07:22 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26322

  17. TYPO3com voted on patch set 9 V +1 08/09/18, 17:23 Completed build in 08m 03s on Thu, 9 Aug, 07:23 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26323

  18. Markus Klein commented on patch set 9 CR -1 08/09/18, 17:55

    reviewing
  19. Markus Klein commented on patch set 9 08/09/18, 18:16

    will correct the exceptions

    SaltFactory.php:53

    IMO this is the wrong exception. We need a logic exception here, because the issue is trigged due to wrong programming
  20. Christian Kuhn commented on patch set 9 08/09/18, 18:29

    SaltFactory.php:53 Reply

    does not matter much. I can change to LogicException, but both Runtime and Logic are top level exceptions, so both can't and should not be caught in normal usage.
  21. Markus Klein uploaded patch set 10 08/09/18, 18:30

  22. TYPO3com voted on patch set 10 V +1 08/09/18, 18:37 Completed build in 06m 52s on Thu, 9 Aug, 08:37 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26324

  23. Markus Klein voted on patch set 10 V +1 CR +1 08/09/18, 18:37

  24. Andreas Kienast voted on patch set 10 V +2 CR +2 08/09/18, 18:39

  25. Andreas Kienast merged patch set 11 08/09/18, 18:39