57847[TASK] Refactor SaltFactory
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Markus Klein +1
-
Verified V +2
- Andreas Kienast +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+23 −12
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+11 −6
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85796-SaltedPasswordsCleanups.rstnew+49 −0
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+3 −2
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+19 −12
- typo3/sysext/install/Classes/Controller/InstallerController.php+2 −3
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+2 −2
- typo3/sysext/install/Classes/Controller/SettingsController.php+2 −2
- typo3/sysext/install/Classes/Http/RequestHandler.php+2 −2
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+12 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+28 −0
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+24 −28
- typo3/sysext/saltedpasswords/Classes/Salt/SaltFactory.php2+91 −20
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php+2 −0
- typo3/sysext/saltedpasswords/Classes/SaltedPasswordService.php+4 −0
- typo3/sysext/saltedpasswords/Documentation/DevelopersGuide/Index.rst+12 −20
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+74 −91
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/SaltFactoryTest.phpnew+148 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+10 −2
Review log 1929
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 08/09/18, 15:48
-
Christian Kuhn uploaded patch set 2 08/09/18, 15:48
-
TYPO3com voted on patch set 1 V -1 08/09/18, 15:48 Completed build in 28s on Thu, 9 Aug, 05:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26311
-
TYPO3com voted on patch set 2 V +1 08/09/18, 16:01 Completed build in 12m 46s on Thu, 9 Aug, 06:01 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26312
-
Christian Kuhn uploaded patch set 3 08/09/18, 16:40
-
Christian Kuhn updated the commit message in patch set 4 08/09/18, 16:42
-
TYPO3com voted on patch set 3 V +1 08/09/18, 16:48 Completed build in 07m 42s on Thu, 9 Aug, 06:48 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26316
-
Christian Kuhn updated the commit message in patch set 5 08/09/18, 16:50
-
Christian Kuhn commented on patch set 6 08/09/18, 16:50
Published edit on patch set 5. -
TYPO3com voted on patch set 4 V +1 08/09/18, 16:51 Completed build in 08m 57s on Thu, 9 Aug, 06:51 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26317
-
TYPO3com voted on patch set 5 V +1 08/09/18, 16:58 Completed build in 08m 19s on Thu, 9 Aug, 06:58 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26319
-
TYPO3com voted on patch set 6 V +1 08/09/18, 16:59 Completed build in 08m 12s on Thu, 9 Aug, 06:59 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26320
-
Markus Klein updated the commit message in patch set 7 08/09/18, 17:03
-
Andreas Kienast commented on patch set 7 CR -1 08/09/18, 17:10
on it -
TYPO3com voted on patch set 7 V +1 08/09/18, 17:11 Completed build in 07m 15s on Thu, 9 Aug, 07:11 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26321
-
Andreas Kienast uploaded patch set 8 08/09/18, 17:14
-
Andreas Kienast uploaded patch set 9 08/09/18, 17:15
-
Wouter Wolters voted on patch set 9 CR +1 08/09/18, 17:19
-
Andreas Kienast commented on patch set 9 V +1 CR +1 08/09/18, 17:21
Tested backend login, password change with login, frontend login. -
TYPO3com voted on patch set 8 V +1 08/09/18, 17:22 Completed build in 07m 44s on Thu, 9 Aug, 07:22 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26322
-
TYPO3com voted on patch set 9 V +1 08/09/18, 17:23 Completed build in 08m 03s on Thu, 9 Aug, 07:23 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26323
-
Markus Klein commented on patch set 9 CR -1 08/09/18, 17:55
reviewing -
Markus Klein commented on patch set 9 08/09/18, 18:16
will correct the exceptionsSaltFactory.php:53IMO this is the wrong exception. We need a logic exception here, because the issue is trigged due to wrong programming -
Christian Kuhn commented on patch set 9 08/09/18, 18:29
SaltFactory.php:53Replydoes not matter much. I can change to LogicException, but both Runtime and Logic are top level exceptions, so both can't and should not be caught in normal usage. -
Markus Klein uploaded patch set 10 08/09/18, 18:30
-
TYPO3com voted on patch set 10 V +1 08/09/18, 18:37 Completed build in 06m 52s on Thu, 9 Aug, 08:37 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26324
-
Markus Klein voted on patch set 10 V +1 CR +1 08/09/18, 18:37
-
Andreas Kienast voted on patch set 10 V +2 CR +2 08/09/18, 18:39
-
Andreas Kienast merged patch set 11 08/09/18, 18:39