Review main Merged

57850[TASK] Make password hash selection an install tool preset

Christian Kuhn CR +2 V +2 Nightmare +3616 −1582 updated 08/11/18, 17:11

Commit message

With this change, the password hash code in salted passwords is
reduced to the SaltFactory with two methods and the single hash
classes that implement SaltInterface without further public
methods. Everything else including the utility classes is
deprecated.
The change moves the LocalConfiguration.php config options around,
adds a settings preset for hash mechanism selection, adds according
silent upgrades, adds 'best available' hash mechanism selection
at installation time and drops the last saltedpasswords
ext_conf_template.txt option.

Details:
* Remove the password hash selection from saltedpasswords config
  namespace and put to TYPO3_CONF_VARS/BE/passwordHashing/className
  and TYPO3_CONF_VARS/FE/passwordHashing/className
* Move available password hash registry from
  TYPO3_CONF_VARS/SC_OPTIONS/ext/saltedpasswords/saltMethods
  to TYPO3_CONF_VARS/SYS/availablePasswordHashAlgorithms
* Add a setting preset to select one of argon2i (preferred),
  bcrypt, pbkdf2 or phpass (last fallback)
* Use 'best matching preset' during installation to select a good
  salt mechanism by default
* Silently upgrade existing password hash selection and upgrade
  to one of the four hash algorithms above
* Allow algorithm specific options in
  TYPO3_CONF_VARS/BE/passwordHashing/options and
  TYPO3_CONF_VARS/FE/passwordHashing/options for admins who
  know what they are doing and need to fiddle with hash details.
* Simplify and refactor the single password hash classes. Deprecate
  a huge list of methods along the way.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 61

Show 41 more files

Review log 2742

Show 1017 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/09/18, 22:42

  2. TYPO3com voted on patch set 1 V -1 08/09/18, 22:42 Completed build in 09s on Fri, 10 Aug, 12:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26331

  3. Christian Kuhn commented on patch set 1 CR -2 08/09/18, 22:43

    preset view in install tool done, everything else missing, though.
  4. Christian Kuhn uploaded patch set 2 08/09/18, 22:45

  5. TYPO3com voted on patch set 2 V +1 08/09/18, 22:51 Completed build in 06m 22s on Fri, 10 Aug, 12:51 AM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26332

  6. Christian Kuhn commented on patch set 2 08/10/18, 00:11

    patch will grow ... to handle this in a good way we need silent upgrade for upgraders, early preset detection during installation, option handling for specific salts, deprecation of current static config loading, option submission to hash algorithm classes, better hash algorithm interfaces.
  7. Christian Kuhn commented on patch set 2 08/10/18, 00:12

    this is now all connected somehow. i tend to create one patch for the main jobs, then one last patch for the move to core.
  8. Christian Kuhn uploaded patch set 3 08/10/18, 13:32

  9. TYPO3com voted on patch set 3 V -1 08/10/18, 13:40 Completed build in 07m 39s on Fri, 10 Aug, 03:40 PM Test Summary: 1212 of 33827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26362

  10. Christian Kuhn uploaded patch set 4 08/10/18, 22:14

  11. TYPO3com voted on patch set 4 V -1 08/10/18, 22:21 Completed build in 07m 07s on Sat, 11 Aug, 12:21 AM Test Summary: 86 of 33809 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26396

  12. Christian Kuhn uploaded patch set 5 08/10/18, 23:15

  13. TYPO3com voted on patch set 5 V -1 08/10/18, 23:15 Completed build in 09s on Sat, 11 Aug, 01:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26398

  14. Christian Kuhn uploaded patch set 6 08/10/18, 23:17

  15. TYPO3com voted on patch set 6 V +1 08/10/18, 23:24 Completed build in 07m 07s on Sat, 11 Aug, 01:24 AM Test Summary: 34554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26399

  16. Christian Kuhn uploaded patch set 7 08/11/18, 01:50

  17. TYPO3com voted on patch set 7 V -1 08/11/18, 01:51 Completed build in 13s on Sat, 11 Aug, 03:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26403

  1. Christian Kuhn uploaded patch set 8 08/11/18, 01:52

  2. Christian Kuhn uploaded patch set 9 08/11/18, 02:00

  3. Christian Kuhn updated the commit message in patch set 10 08/11/18, 02:01

  4. TYPO3com voted on patch set 10 V +1 08/11/18, 02:08 Completed build in 06m 15s on Sat, 11 Aug, 04:08 AM Test Summary: 34584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26405

  5. Christian Kuhn uploaded patch set 11 08/11/18, 12:02

  6. TYPO3com voted on patch set 11 V -1 08/11/18, 12:08 Completed build in 06m 05s on Sat, 11 Aug, 02:08 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26421

  7. Christian Kuhn uploaded patch set 12 08/11/18, 12:10

  8. TYPO3com voted on patch set 12 V +1 08/11/18, 12:18 Completed build in 07m 43s on Sat, 11 Aug, 02:18 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26422

  9. Christian Kuhn updated the commit message in patch set 13 08/11/18, 12:20

  10. TYPO3com voted on patch set 13 V +1 08/11/18, 12:27 Completed build in 07m 04s on Sat, 11 Aug, 02:27 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26423

  11. Christian Kuhn uploaded patch set 14 08/11/18, 12:47

  12. TYPO3com voted on patch set 14 V +1 08/11/18, 12:56 Completed build in 08m 45s on Sat, 11 Aug, 02:56 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26424

  13. Christian Kuhn uploaded patch set 15 08/11/18, 14:53

  14. TYPO3com voted on patch set 15 V -1 08/11/18, 14:54 Completed build in 05s on Sat, 11 Aug, 04:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26429

  15. Christian Kuhn uploaded patch set 16 08/11/18, 14:56

  16. Christian Kuhn updated the commit message in patch set 17 08/11/18, 15:01

  17. Christian Kuhn voted on patch set 17 CR 0 08/11/18, 15:01

  18. TYPO3com voted on patch set 16 V +1 08/11/18, 15:07 Completed build in 10m 34s on Sat, 11 Aug, 05:07 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26431

  19. TYPO3com voted on patch set 17 V +1 08/11/18, 15:09 Completed build in 08m 10s on Sat, 11 Aug, 05:09 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26432

  20. Benni Mack voted on patch set 17 V +1 CR +1 08/11/18, 15:40

  21. Andreas Kienast voted on patch set 17 V +1 CR +1 08/11/18, 16:20

  22. Christian Kuhn voted on patch set 17 V +2 CR +2 08/11/18, 16:22

  23. Christian Kuhn merged patch set 18 08/11/18, 16:22

  24. Wouter Wolters commented on patch set 18 08/11/18, 17:07

    Argon2iPreset.php:52

    :bool

    BcryptPreset.php:52

    :bool

    CustomPreset.php:34

    :array

    Pbkdf2Preset.php:52

    :bool

    PhpassPreset.php:52

    :bool

    Argon2iSalt.php:55

    @throws

    BcryptSalt.php:53

    @throws

    BlowfishSalt.php:87

    @throws
  25. Christian Kuhn commented on patch set 18 08/11/18, 17:11

    thx wouter! i'll take care of the glitches in my final saltedpasswords patch.