57850[TASK] Make password hash selection an install tool preset
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Andreas Kienast +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 61
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −6
- typo3/sysext/core/Configuration/DefaultConfiguration.php+16 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+29 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85804-SaltedPasswordHashClassDeprecations.rstnew+136 −0
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php+4 −4
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+1 −1
- typo3/sysext/install/Classes/Configuration/Image/ImageFeature.php+1 −1
- typo3/sysext/install/Classes/Configuration/PasswordHashing/Argon2iPreset.php1new+56 −0
- typo3/sysext/install/Classes/Configuration/PasswordHashing/BcryptPreset.php1new+56 −0
- typo3/sysext/install/Classes/Configuration/PasswordHashing/CustomPreset.php1new+51 −0
- typo3/sysext/install/Classes/Configuration/PasswordHashing/PasswordHashingFeature.phpnew+41 −0
- typo3/sysext/install/Classes/Configuration/PasswordHashing/Pbkdf2Preset.php1new+56 −0
- typo3/sysext/install/Classes/Configuration/PasswordHashing/PhpassPreset.php1new+56 −0
- typo3/sysext/install/Classes/Configuration/FeatureManager.php+2 −0
- typo3/sysext/install/Classes/Controller/InstallerController.php+28 −4
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+1 −1
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+108 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassConstantMatcher.php+65 −0
Show 41 more files
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+20 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/InterfaceMethodChangedMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+28 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+273 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Argon2i.htmlnew+33 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Bcrypt.htmlnew+32 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Custom.htmlnew+37 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Pbkdf2.htmlnew+32 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing/Phpass.htmlnew+32 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing.htmlnew+32 −0
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+147 −6
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Salt/AbstractComposedSalt.php+7 −39
- typo3/sysext/saltedpasswords/Classes/Salt/Argon2iSalt.php1+44 −3
- typo3/sysext/saltedpasswords/Classes/Salt/BcryptSalt.php1+54 −29
- typo3/sysext/saltedpasswords/Classes/Salt/BlowfishSalt.php1+279 −145
- typo3/sysext/saltedpasswords/Classes/Salt/ComposedSaltInterface.php+2 −0
- typo3/sysext/saltedpasswords/Classes/Salt/Md5Salt.php+163 −122
- typo3/sysext/saltedpasswords/Classes/Salt/Pbkdf2Salt.php+252 −230
- typo3/sysext/saltedpasswords/Classes/Salt/PhpassSalt.php+245 −185
- typo3/sysext/saltedpasswords/Classes/Salt/SaltFactory.php+55 −31
- typo3/sysext/saltedpasswords/Classes/Salt/SaltInterface.php+1 −2
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+10 −0
- typo3/sysext/saltedpasswords/Classes/Utility/SaltedPasswordsUtility.php+12 −2
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Fixtures/TestSalt.phpnew+34 −0
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Argon2iSaltTest.php+26 −38
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/BcryptSaltTest.php+19 −24
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/BlowfishSaltTest.php+58 −187
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Md5SaltTest.php+46 −115
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Pbkdf2SaltTest.php+62 −166
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/PhpassSaltTest.php+63 −176
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/SaltFactoryTest.php+134 −11
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/Argon2iSaltTest.phpnew+73 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/BcryptSaltTest.phpnew+64 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/BlowfishSaltTest.phpnew+148 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/Md5SaltTest.phpnew+89 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/Pbkdf2SaltTest.phpnew+138 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/PhpassSaltTest.phpnew+146 −0
- typo3/sysext/saltedpasswords/Tests/UnitDeprecated/Salt/SaltFactoryTest.php+0 −44
- typo3/sysext/saltedpasswords/ext_conf_template.txtdeleted+0 −5
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
Review log 2742
Show 1017 earlier messages
-
Christian Kuhn uploaded patch set 1 08/09/18, 22:42
-
TYPO3com voted on patch set 1 V -1 08/09/18, 22:42 Completed build in 09s on Fri, 10 Aug, 12:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26331
-
Christian Kuhn commented on patch set 1 CR -2 08/09/18, 22:43
preset view in install tool done, everything else missing, though. -
Christian Kuhn uploaded patch set 2 08/09/18, 22:45
-
TYPO3com voted on patch set 2 V +1 08/09/18, 22:51 Completed build in 06m 22s on Fri, 10 Aug, 12:51 AM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26332
-
Christian Kuhn commented on patch set 2 08/10/18, 00:11
patch will grow ... to handle this in a good way we need silent upgrade for upgraders, early preset detection during installation, option handling for specific salts, deprecation of current static config loading, option submission to hash algorithm classes, better hash algorithm interfaces. -
Christian Kuhn commented on patch set 2 08/10/18, 00:12
this is now all connected somehow. i tend to create one patch for the main jobs, then one last patch for the move to core. -
Christian Kuhn uploaded patch set 3 08/10/18, 13:32
-
TYPO3com voted on patch set 3 V -1 08/10/18, 13:40 Completed build in 07m 39s on Fri, 10 Aug, 03:40 PM Test Summary: 1212 of 33827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26362
-
Christian Kuhn uploaded patch set 4 08/10/18, 22:14
-
TYPO3com voted on patch set 4 V -1 08/10/18, 22:21 Completed build in 07m 07s on Sat, 11 Aug, 12:21 AM Test Summary: 86 of 33809 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26396
-
Christian Kuhn uploaded patch set 5 08/10/18, 23:15
-
TYPO3com voted on patch set 5 V -1 08/10/18, 23:15 Completed build in 09s on Sat, 11 Aug, 01:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26398
-
Christian Kuhn uploaded patch set 6 08/10/18, 23:17
-
TYPO3com voted on patch set 6 V +1 08/10/18, 23:24 Completed build in 07m 07s on Sat, 11 Aug, 01:24 AM Test Summary: 34554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26399
-
Christian Kuhn uploaded patch set 7 08/11/18, 01:50
-
TYPO3com voted on patch set 7 V -1 08/11/18, 01:51 Completed build in 13s on Sat, 11 Aug, 03:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26403
-
Christian Kuhn uploaded patch set 8 08/11/18, 01:52
-
Christian Kuhn uploaded patch set 9 08/11/18, 02:00
-
Christian Kuhn updated the commit message in patch set 10 08/11/18, 02:01
-
TYPO3com voted on patch set 10 V +1 08/11/18, 02:08 Completed build in 06m 15s on Sat, 11 Aug, 04:08 AM Test Summary: 34584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26405
-
Christian Kuhn uploaded patch set 11 08/11/18, 12:02
-
TYPO3com voted on patch set 11 V -1 08/11/18, 12:08 Completed build in 06m 05s on Sat, 11 Aug, 02:08 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26421
-
Christian Kuhn uploaded patch set 12 08/11/18, 12:10
-
TYPO3com voted on patch set 12 V +1 08/11/18, 12:18 Completed build in 07m 43s on Sat, 11 Aug, 02:18 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26422
-
Christian Kuhn updated the commit message in patch set 13 08/11/18, 12:20
-
TYPO3com voted on patch set 13 V +1 08/11/18, 12:27 Completed build in 07m 04s on Sat, 11 Aug, 02:27 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26423
-
Christian Kuhn uploaded patch set 14 08/11/18, 12:47
-
TYPO3com voted on patch set 14 V +1 08/11/18, 12:56 Completed build in 08m 45s on Sat, 11 Aug, 02:56 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26424
-
Christian Kuhn uploaded patch set 15 08/11/18, 14:53
-
TYPO3com voted on patch set 15 V -1 08/11/18, 14:54 Completed build in 05s on Sat, 11 Aug, 04:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26429
-
Christian Kuhn uploaded patch set 16 08/11/18, 14:56
-
Christian Kuhn updated the commit message in patch set 17 08/11/18, 15:01
-
Christian Kuhn voted on patch set 17 CR 0 08/11/18, 15:01
-
TYPO3com voted on patch set 16 V +1 08/11/18, 15:07 Completed build in 10m 34s on Sat, 11 Aug, 05:07 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26431
-
TYPO3com voted on patch set 17 V +1 08/11/18, 15:09 Completed build in 08m 10s on Sat, 11 Aug, 05:09 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26432
-
Benni Mack voted on patch set 17 V +1 CR +1 08/11/18, 15:40
-
Andreas Kienast voted on patch set 17 V +1 CR +1 08/11/18, 16:20
-
Christian Kuhn voted on patch set 17 V +2 CR +2 08/11/18, 16:22
-
Christian Kuhn merged patch set 18 08/11/18, 16:22
-
Wouter Wolters commented on patch set 18 08/11/18, 17:07
Argon2iPreset.php:52:boolBcryptPreset.php:52:boolCustomPreset.php:34:arrayPbkdf2Preset.php:52:boolPhpassPreset.php:52:boolArgon2iSalt.php:55@throwsBcryptSalt.php:53@throwsBlowfishSalt.php:87@throws -
Christian Kuhn commented on patch set 18 08/11/18, 17:11
thx wouter! i'll take care of the glitches in my final saltedpasswords patch.