Review main Merged

57852[TASK] Clean up code due to Context API deprecations

Benni Mack CR +2 V +2 Normal +25 −42 updated 08/10/18, 09:29

Commit message

The TSFE object does not use $gr_list, $showHiddenPage, $loginUser etc.
anymore, and the deprecations in place (via magic methods) do not expect the
properties to be filled at all anymore.

Some comments are adjusted.

Additionally, some tests where a global TSFE is not necessary anymore, are adapted.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Richard Vollebregt +1
    • Christian Kuhn +1
    • Riny van Tiggelen +1
    • Mona Muzaffar +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Benni Mack uploaded patch set 1 08/10/18, 07:41

  2. TYPO3com voted on patch set 1 V +1 08/10/18, 07:48 Completed build in 06m 38s on Fri, 10 Aug, 09:48 AM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26334

  3. Wouter Wolters voted on patch set 1 CR +1 08/10/18, 08:29

  4. Mona Muzaffar voted on patch set 1 CR +1 08/10/18, 08:37

  5. Riny van Tiggelen voted on patch set 1 CR +1 08/10/18, 08:38

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 08/10/18, 08:45

  7. Richard Vollebregt voted on patch set 1 CR +1 08/10/18, 09:04

  8. Wouter Wolters voted on patch set 1 V +2 CR +2 08/10/18, 09:29

  9. Wouter Wolters merged patch set 2 08/10/18, 09:29