57855[TASK] Add php extension PDO to master and sub packages
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Mona Muzaffar +1
- Mathias Brodala +1
-
Verified V +2
- Wouter Wolters +2
- Mona Muzaffar +1
- Mathias Brodala +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1518
-
Anja Leichsenring uploaded patch set 1 08/10/18, 10:03
-
Anja Leichsenring commented on patch set 1 08/10/18, 10:04
composer require ext-pdo (lowercased) results in the uppercased variation for me. Also, the version was chosen by composer on its own. What do you think? For the other PHP extensions we settle for lower casing and no version constraint. -
Mathias Brodala commented on patch set 1 CR -1 08/10/18, 10:07
composer.json:35Please use "*" instead, see: https://getcomposer.org/doc/01-basic-usage.md#platform-packages -
Mathias Brodala commented on patch set 1 08/10/18, 10:10
> composer require ext-pdo (lowercased) results in the uppercased > variation for me. Also, the version was chosen by composer on its > own. What do you think? For the other PHP extensions we settle for > lower casing and no version constraint. For extensions please always use this: composer req ext-foo "*" -
TYPO3com voted on patch set 1 V +1 08/10/18, 10:12 Completed build in 08m 52s on Fri, 10 Aug, 12:12 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26347
-
Anja Leichsenring uploaded patch set 2 08/10/18, 10:26
-
Mathias Brodala voted on patch set 2 V +1 CR +1 08/10/18, 10:27
-
Wouter Wolters voted on patch set 2 CR +1 08/10/18, 10:30
-
Mona Muzaffar voted on patch set 2 V +1 CR +1 08/10/18, 10:32
-
TYPO3com voted on patch set 2 V +1 08/10/18, 10:33 Completed build in 06m 55s on Fri, 10 Aug, 12:33 PM Test Summary: 33687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26349
-
Benni Mack commented on patch set 2 CR -1 08/10/18, 12:05
sorry for destryoing the fun here. as we haven't fully set up dependencies in all system extensions (rather give them only a dependency to EXT:core), I suggest to add it to the root composer.json and EXT:core/composer.json. We need to structure and come up with a full plan to completely define all dependencies for each system extension - ideally also with a script to not have this done manually. -
Mona Muzaffar uploaded patch set 3 08/10/18, 12:19
-
TYPO3com voted on patch set 3 V +1 08/10/18, 12:26 Completed build in 07m 41s on Fri, 10 Aug, 02:26 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26357
-
Mathias Brodala voted on patch set 3 V +1 CR +1 08/10/18, 13:24
-
Wouter Wolters voted on patch set 3 CR +1 08/10/18, 13:27
-
Mona Muzaffar voted on patch set 3 V +1 CR +1 08/10/18, 13:31
-
Wouter Wolters voted on patch set 3 V +2 CR +2 08/10/18, 13:35
-
Wouter Wolters merged patch set 4 08/10/18, 13:35