Review main Merged

57859[TASK] Deprecate EnvironmentService::isEnvironmentInCliMode

Wouter Wolters CR +2 V +2 Easy +43 −1 updated 08/10/18, 13:35

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tim Schreiner +1
    • Mathias Brodala +1
  • Verified V +2
    • Wouter Wolters +2
    • Tim Schreiner +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Wouter Wolters uploaded patch set 1 08/10/18, 13:10

  2. TYPO3com voted on patch set 1 V +1 08/10/18, 13:16 Completed build in 06m 11s on Fri, 10 Aug, 03:16 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26361

  3. Tim Schreiner voted on patch set 1 V +1 CR +1 08/10/18, 13:21

  4. Mathias Brodala voted on patch set 1 V +1 CR +1 08/10/18, 13:21

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 08/10/18, 13:35

  6. Wouter Wolters merged patch set 2 08/10/18, 13:35